Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
We have at least 3 distinct IDs in use for routes:
ID
inroute.Route
, which is the ID in the databaseNetID
inroute.Route
, which is the Name/ID in the dashboardHAUniqueID
which is a combination ofRoute.NetID
andRoute.Network
Having so many IDs using all
string
it's hard to distinguish them from each other.This PR refactors the IDs to use dedicated types to avoid mixing them up.
Conversions from/to
string
must be done explicitly. Conversions between the types must not happen.Issue ticket number and link
Checklist