Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore cloned routes on bsd #1915

Merged
merged 1 commit into from
May 2, 2024
Merged

Ignore cloned routes on bsd #1915

merged 1 commit into from
May 2, 2024

Conversation

lixmal
Copy link
Contributor

@lixmal lixmal commented May 2, 2024 •
edited
Loading

Describe your changes

Sometimes the bsd routing table contains routes with the flag W:

W RTF_WASCLONED Route was generated as a result of cloning

These routes only appear using the a flag:
netstat -nra

This prevents us from creating routes for netbird.
This change ignores routes of this type and creates the routes, overriding the cloned ones.

Issue ticket number and link

#1900

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@lixmal lixmal merged commit 6a49351 into main May 2, 2024
16 checks passed
@lixmal lixmal deleted the fix/bsd-ignore-cloned branch May 2, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlsmaycon mlsmaycon mlsmaycon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lixmal @mlsmaycon