Add route selection to iOS #1944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/add-route-selction-to-ios
# Conflicts: # client/internal/routemanager/client.go # client/server/route.go
pascal-fischer
changed the title
* wrap clientRun into struct and remove engine chan
pappz
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR adds support for the route selection feature for iOS. It adds the required methods to be used from the Swift code to list, select and unselect routes. It also adds the notification for the NetworkChangeListener in case of a route change.
Additionally, this PR adds a more detailed status update about the peers so that the UI of the app can show details similar to what the
netbird status -dcommand is showing.Issue ticket number and link
Checklist