[management] Restrict accessible peers to user-owned peers for non-admins #2618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
bcmmbaga
force-pushed
the
add-accessible-peers-role-permissions
branch
from
224641a to
0a941f4
Compare
mlsmaycon
requested changes
Sep 19, 2024
| @@ -228,6 +228,20 @@ func (h *PeersHandler) GetAccessiblePeers(w http.ResponseWriter, r *http.Request | |||
| return | |||
| } | |||
|
|
|||
| if !user.HasAdminPower() && !user.IsServiceUser { | |||
| peer, err := h.accountManager.GetPeer(r.Context(), account.Id, peerID, user.Id) | |||
There was a problem hiding this comment.
We are introducing an unnecessary get account here. I suggest either optimizing the GetPeer or reusing the account in line 218, but consider PR #2615
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
|
mlsmaycon
reviewed
Sep 20, 2024
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
mlsmaycon
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist