[client] Limit P2P attempts and restart on specific events #2657
Conversation
There was a problem hiding this comment.
Does it make no sense to move this file into a separate structure? I do not see any dependency from the conn that is not exchangeable.
There was a problem hiding this comment.
Sonar will complain :)
There was a problem hiding this comment.
That the file is too large
There was a problem hiding this comment.
I can not follow you. If you move everything from conn_monitor.go to monitor.go and in it create a
type ConnMonitor struct {
}
Then we can get a better separated code structure that is better testable by unit tests.
There was a problem hiding this comment.
I have moved it to a separate struct. But not its own package yet because that requires more refactoring on the other components
There was a problem hiding this comment.
This looks nice! I will review it again.
lixmal
changed the title
Co-authored-by: Maycon Santos <mlsmaycon@gmail.com>
Co-authored-by: Maycon Santos <mlsmaycon@gmail.com>
|
Describe your changes
Issue ticket number and link
Checklist