Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install sh alpine fixes #2678

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Conversation

simen64
Copy link
Contributor

@simen64 simen64 commented Sep 30, 2024

Describe your changes

  1. Made the script check for doas to work with alpine linux
  2. Specified a set DNS server in the curl statement that downloads the binaries. I had issues where the curl request wouldnt resolve the URL, my theory is that since one of the redirect URL's are very long the standard DNS wont resolve it. This is what i experienced on alpine linux, and setting the google dns in the curl request fixed the issue.
  3. Change "-C" to "-c" in the sort statement, the sort version in alpine linux doesnt have the "-C" function and it works just as well with "-c"

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@CLAassistant
Copy link

CLAassistant commented Sep 30, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

Copy link
Collaborator

@mlsmaycon mlsmaycon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @simen64 for the contribution.

@mlsmaycon mlsmaycon merged commit 24c0aaa into netbirdio:main Oct 1, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants