Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor getAccountIDWithAuthorizationClaims #2715

Merged
merged 11 commits into from
Oct 12, 2024
Merged

Refactor getAccountIDWithAuthorizationClaims #2715

merged 11 commits into from
Oct 12, 2024

Conversation

mlsmaycon
Copy link
Collaborator

@mlsmaycon mlsmaycon commented Oct 9, 2024 •
edited
Loading

Describe your changes

This change restructures the getAccountIDWithAuthorizationClaims method to improve readability, maintainability, and performance.

  • have dedicated methods to handle possible cases
  • introduced Store.UpdateAccountDomainAttributes and Store.GetAccountUsers methods
  • Remove GetAccount and SaveAccount dependency
  • added tests

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@mlsmaycon mlsmaycon marked this pull request as ready for review October 10, 2024 21:51
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mlsmaycon mlsmaycon merged commit da3a053 into main Oct 12, 2024
21 checks passed
@mlsmaycon mlsmaycon deleted the refactor/new-account-check branch October 12, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcmmbaga bcmmbaga bcmmbaga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlsmaycon @bcmmbaga