[client] Fix controller re-connection #2758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use endpoints in threadsafe way
- add comments - fix close logic
pappz
changed the title
lixmal
reviewed
Oct 23, 2024
| @@ -10,6 +12,7 @@ type USPFactory struct { | |||
| } | |||
|
|
|||
| func NewUSPFactory(iceBind *bind.ICEBind) *USPFactory { | |||
| log.Infof("WireGuard Proxy Factory will produce bind proxy") | |||
There was a problem hiding this comment.
Should these new logs be Debug level?
There was a problem hiding this comment.
No, this log line is really important to know in any case. And it will appear only once time. We support 3 different implementation and good to know what is the active.
lixmal
previously approved these changes
Oct 23, 2024
lixmal
previously approved these changes
Oct 24, 2024
|
lixmal
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Rethink the peer reconnection code organization.
Watch these events:
Fixed issues:
Issue ticket number and link
Checklist