Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client] upgrade zcalusic/sysinfo to v1.1.3 (add serial support for ARM arch) #2954

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

EdouardVanbelle
Copy link
Contributor

@EdouardVanbelle EdouardVanbelle commented Nov 25, 2024

Hello please find a library upgrade to zcalusic/sysinfo@v1.1.3 in order to support serial from ARM architectures like Raspberry Pi

for security reason the changes from previous version: https://github.com/zcalusic/sysinfo/compare/v1.0.2..v1.1.3

which brings this pull request: zcalusic/sysinfo#50

note that https://github.com/zcalusic/sysinfo does not generate anymore /etc/machine-id on linux

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

Signed-off-by: Edouard Vanbelle <edouard.vanbelle@shadow.tech>
@EdouardVanbelle EdouardVanbelle changed the title upgrade zcalusic/sysinfo to v1.1.3 (add serial support for ARM arch) [client] upgrade zcalusic/sysinfo to v1.1.3 (add serial support for ARM arch) Nov 25, 2024
@mlsmaycon mlsmaycon requested a review from pappz December 5, 2024 10:34
@pappz
Copy link
Contributor

pappz commented Dec 5, 2024

Dear @EdouardVanbelle
Thank you for your PR! It looks acceptable. I will double-check the changes in the zcalusic/sysinfo and we will see.

@pappz pappz merged commit ff330e6 into netbirdio:main Dec 5, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants