[client] Add stateful userspace firewall and remove egress filters #3093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lixmal
force-pushed
the
remove-egress-filters
branch
from
809d63f to
8216ab6
Compare
|
lixmal
changed the title
pappz
reviewed
Dec 21, 2024
|
|
||
| // TrackOutbound processes an outbound TCP packet and updates connection state | ||
| func (t *TCPTracker) TrackOutbound(srcIP net.IP, dstIP net.IP, srcPort uint16, dstPort uint16, flags uint8) { | ||
| t.mutex.Lock() |
There was a problem hiding this comment.
We can apply the locks later, right before touch the map.
pappz
reviewed
Dec 21, 2024
| // TCPTracker manages TCP connection states | ||
| type TCPTracker struct { | ||
| connections map[TCPConnKey]*TCPConnTrack | ||
| mutex sync.RWMutex |
There was a problem hiding this comment.
It is RWMutex but it has been used without RW feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist