Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code #34

Merged
merged 2 commits into from
Jun 15, 2021
Merged

Remove dead code #34

merged 2 commits into from
Jun 15, 2021

Conversation

stv0g
Copy link
Contributor

@stv0g stv0g commented Jun 15, 2021

Closes #32

@mlsmaycon mlsmaycon requested review from mlsmaycon and braginini June 15, 2021 14:34
@mlsmaycon
Copy link
Collaborator

Thanks, @stv0g for the PR, this was a leftover from an experiment we tried in the early stages of the project.

The lint is failing because of an unused function. As you've opened the PR, can you update your branch and remove the function here as well https://github.com/wiretrustee/wiretrustee/pull/34/files#file-iface-iface-go-L151 ?

@stv0g
Copy link
Contributor Author

stv0g commented Jun 15, 2021

Thanks, @stv0g for the PR, this was a leftover from an experiment we tried in the early stages of the project.

The lint is failing because of an unused function. As you've opened the PR, can you update your branch and remove the function here as well https://github.com/wiretrustee/wiretrustee/pull/34/files#file-iface-iface-go-L151 ?

Done

Copy link
Collaborator

@mlsmaycon mlsmaycon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mlsmaycon mlsmaycon merged commit 6465e25 into netbirdio:main Jun 15, 2021
pulsastrix pushed a commit to pulsastrix/netbird that referenced this pull request Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dead code?
2 participants