[management] do not add ephemeral peer to deletion queue on logout

[crn4]

Describe your changes

Set the ephemeral peer flag to false upon user logout to prevent it from being unnecessarily added to the deletion queue

Issue ticket number and link

Stack

Checklist

• Is it a bug fix
• Is a typo/documentation fix
• Is a feature enhancement
• It is a refactor
• Created tests that fail without the change (if possible)
• Extended the README / documentation, if necessary

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

Pull Request Overview

This PR modifies the logout functionality to prevent ephemeral peers from being added to the deletion queue when a user logs out. The change sets the ephemeral flag to false before proceeding with peer deletion.

• Sets ephemeral peer flag to false during logout to avoid unnecessary deletion queue operations
• Adds explicit call to cancelPeerRoutines before peer deletion

[Copilot]

The call to cancelPeerRoutines appears to be moved from its original location. Verify that this placement is correct and that the peer state modifications (setting Ephemeral to false) don't interfere with the routine cancellation logic.

Suggested change

	// if peer is ephemeral, we need to set it to false to prevent adding it to ephemeral deletion queue
	if peer.Ephemeral {
	peer.Ephemeral = false
	}
	s.cancelPeerRoutines(ctx, peer.AccountID, peer)
	// cancel peer routines before modifying peer state
	s.cancelPeerRoutines(ctx, peer.AccountID, peer)
	// if peer is ephemeral, we need to set it to false to prevent adding it to ephemeral deletion queue
	if peer.Ephemeral {
	peer.Ephemeral = false
	}