[client] Add Windows DNS Policies To GPO Path Always #4460
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the Windows DNS policy configuration to always apply both local and GPO (Group Policy Object) DNS policies, removing the conditional logic that previously only applied one or the other.
- Removes conditional GPO path selection logic
- Always configures both local DNS policies and GPO DNS policies
- Simplifies the policy path determination by removing the index-based naming
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
client/internal/dns/host_windows.go
Outdated
| } | ||
|
|
||
| if err := r.configureDNSPolicy(gpoDnsPolicyConfigMatchPath, domains, ip); err != nil { | ||
| return i, fmt.Errorf("configure local DNS policy: %w", err) |
There was a problem hiding this comment.
The error message 'configure local DNS policy' is misleading since this code is actually configuring the GPO DNS policy, not the local one. It should be 'configure GPO DNS policy' to accurately reflect what failed.
| return i, fmt.Errorf("configure local DNS policy: %w", err) | |
| return i, fmt.Errorf("configure GPO DNS policy: %w", err) |
Copilot uses AI. Check for mistakes.
|
[client] Add Windows DNS Policies To GPO Path Always
Describe your changes
Issue ticket number and link
Stack
Checklist
Documentation
Select exactly one:
.
Docs PR URL (required if "docs added" is checked)
Paste the PR link from https://github.com/netbirdio/docs here:
https://github.com/netbirdio/docs/pull/__