Skip to content

Conversation

bcmmbaga
Copy link
Contributor

@bcmmbaga bcmmbaga commented Sep 9, 2025

Describe your changes

Issue ticket number and link

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Documentation

Select exactly one:

  • I added/updated documentation for this change
  • Documentation is not needed for this change (explain why)

Docs PR URL (required if "docs added" is checked)

Paste the PR link from https://github.com/netbirdio/docs here:

https://github.com/netbirdio/docs/pull/__

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
@bcmmbaga bcmmbaga marked this pull request as ready for review September 9, 2025 12:45
@Copilot Copilot AI review requested due to automatic review settings September 9, 2025 12:45
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new disapproval_reason field to peer objects to provide context about why a peer requires approval in cloud environments. The change extends the existing approval system by capturing and exposing the specific reason when a peer is not validated.

  • Adds DisapprovalReason field to Peer and PeerBatch API types
  • Updates the integrated validator interface to return disapproval reasons alongside validation results
  • Modifies peer handlers to include disapproval reasons in API responses

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
shared/management/http/api/types.gen.go Adds DisapprovalReason field to Peer and PeerBatch structs
shared/management/http/api/openapi.yml Adds disapproval_reason field to OpenAPI schema
management/server/peer.go Updates GetValidatedPeers calls to handle new return parameter
management/server/mock_server/account_mock.go Updates mock implementation to return disapproval reasons
management/server/integrations/integrated_validator/interface.go Updates interface signature to return disapproval reasons map
management/server/integrated_validator.go Updates implementation to return disapproval reasons
management/server/http/handlers/peers/peers_handler.go Updates handlers to process and include disapproval reasons in responses
management/server/account/manager.go Updates Manager interface signature
go.mod Updates management-integrations dependency version

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
Copy link

sonarqubecloud bot commented Sep 9, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant