-
-
Notifications
You must be signed in to change notification settings - Fork 876
[management] Add peer disapproval reason #4468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new disapproval_reason
field to peer objects to provide context about why a peer requires approval in cloud environments. The change extends the existing approval system by capturing and exposing the specific reason when a peer is not validated.
- Adds
DisapprovalReason
field to Peer and PeerBatch API types - Updates the integrated validator interface to return disapproval reasons alongside validation results
- Modifies peer handlers to include disapproval reasons in API responses
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
shared/management/http/api/types.gen.go | Adds DisapprovalReason field to Peer and PeerBatch structs |
shared/management/http/api/openapi.yml | Adds disapproval_reason field to OpenAPI schema |
management/server/peer.go | Updates GetValidatedPeers calls to handle new return parameter |
management/server/mock_server/account_mock.go | Updates mock implementation to return disapproval reasons |
management/server/integrations/integrated_validator/interface.go | Updates interface signature to return disapproval reasons map |
management/server/integrated_validator.go | Updates implementation to return disapproval reasons |
management/server/http/handlers/peers/peers_handler.go | Updates handlers to process and include disapproval reasons in responses |
management/server/account/manager.go | Updates Manager interface signature |
go.mod | Updates management-integrations dependency version |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
|
Describe your changes
Issue ticket number and link
Stack
Checklist
Documentation
Select exactly one:
Docs PR URL (required if "docs added" is checked)
Paste the PR link from https://github.com/netbirdio/docs here:
https://github.com/netbirdio/docs/pull/__