Add SetupKey auto-groups property #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braginini
changed the title
|
Relates to |
mlsmaycon
requested changes
Sep 11, 2022
|
|
||
| func (h *SetupKeys) GetKeys(w http.ResponseWriter, r *http.Request) { | ||
| writeSuccess(w, key) |
There was a problem hiding this comment.
we should call toResponseBody function before responding.
There was a problem hiding this comment.
writeSuccess function does toResponseBody
func writeSuccess(w http.ResponseWriter, key *server.SetupKey) {
w.WriteHeader(200)
w.Header().Set("Content-Type", "application/json")
err := json.NewEncoder(w).Encode(toResponseBody(key))
if err != nil {
http.Error(w, "failed handling request", http.StatusInternalServerError)
return
}
}
|
|
||
| func (h *SetupKeys) GetKeys(w http.ResponseWriter, r *http.Request) { | ||
| writeSuccess(w, key) |
There was a problem hiding this comment.
we should call toResponseBody function before responding.
There was a problem hiding this comment.
writeSuccess function does toResponseBody
func writeSuccess(w http.ResponseWriter, key *server.SetupKey) {
w.WriteHeader(200)
w.Header().Set("Content-Type", "application/json")
err := json.NewEncoder(w).Encode(toResponseBody(key))
if err != nil {
http.Error(w, "failed handling request", http.StatusInternalServerError)
return
}
}
| UsedTimes: key.UsedTimes, | ||
| LastUsed: key.LastUsed, | ||
| State: state, | ||
| AutoGroups: key.AutoGroups, |
There was a problem hiding this comment.
should we consider returning []api.GroupMinimum?
mlsmaycon
approved these changes
Sep 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend Management API to add support for setup keys auto-tagging feature that allows automatic groups assignment to peers that used the key.
This PR just adds the property to the setup key.
Works as the first feature MVP for this request #458 (comment)