Installation fails if /etc/firejail/login.users exists

[Fred-Barclay]

Bug and expected behavior
When compiling from source from latest with ./configure --prefix=/usr && make && sudo make install-strip #or install the process errors with the message:

[ ! -f /etc/firejail/login.users ] && install -m 0644 etc/login.users /etc/firejail
make[1]: *** [Makefile:118: realinstall] Error 1
make[1]: Leaving directory '/home/fred/firejail'
make: *** [Makefile:156: install-strip] Error 2

I believe the issue started some point after 378d0e6, possibly due to dae3933 or the few commits following.

Relevant line seems to be

firejail/Makefile.in

Line 125 in 0b23731

[ ! -f $(DESTDIR)$(sysconfdir)/firejail/login.users ] && install -m 0644 etc/login.users $(DESTDIR)$(sysconfdir)/firejail

Not entirely sure why it gives up and dies, not super familiar with makefiles... 😕

Environment

$ sb_release -a
No LSB modules are available.
Distributor ID:	Linuxmint
Description:	LMDE 4 (debbie)
Release:	4
Codename:	debbie

$ cat /etc/debian_version 
10.2

[rusty-snake]

can you try this:

[ ! -f $(DESTDIR)$(sysconfdir)/firejail/login.users ] && install -m 0644 etc/login.users $(DESTDIR)$(sysconfdir)/firejail/login.users

[Fred-Barclay]

@rusty-snake no change :(

[glitsj16]

I noticed this too as stated in #3450 (comment). At the moment, the only way I can reliably build from git master on Ubuntu is by reverting 52e24db and dae3933. Can't explain why though...

[rusty-snake]

Then let's revert this changes completely, I will commit later.

sh -c "if [ ! -f $(DESTDIR)/$(sysconfdir)/firejail/login.users ]; then install -c -m 0644 etc/login.users $(DESTDIR)/$(sysconfdir)/firejail/.; fi;"

sh -c "if [ ! -d $(DESTDIR)/$(sysconfdir)/apparmor.d ]; then install -d -m 755 $(DESTDIR)/$(sysconfdir)/apparmor.d; fi;"

sh -c "if [ ! -d $(DESTDIR)/$(sysconfdir)/apparmor.d/local ]; then install -d -m 755 $(DESTDIR)/$(sysconfdir)/apparmor.d/local; fi;"

sh -c "if [ ! -f $(DESTDIR)/$(sysconfdir)/apparmor.d/local/firejail-local ]; then install -c -m 0644 etc/apparmor/firejail-local $(DESTDIR)/$(sysconfdir)/apparmor.d/local/.; fi;"

[rusty-snake]

@Fred-Barclay @glitsj16 ^^

[glitsj16]

@rusty-snake For me this is fixed now on Ubuntu 16.04 LTS. Thanks!

[Fred-Barclay]

@rusty-snake I haven't been able to check on my Debian box but it seems good now on my Ubuntu 20.04 - thanks! 😄