Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No more way to specify custom configure options when building deb? #3523

Closed
laniakea64 opened this issue Jul 18, 2020 · 10 comments · Fixed by #3621
Closed

No more way to specify custom configure options when building deb? #3523

laniakea64 opened this issue Jul 18, 2020 · 10 comments · Fixed by #3621

Comments

@laniakea64
Copy link
Contributor

Building firejail from 9ecd3ca is not possible with fj-mkdeb.py -

$ ./contrib/fj-mkdeb.py --enable-apparmor --disable-firetunnel
Error: Could not find the firejail source tree.  Exiting.

This is probably as of 87e7b31 , where mkdeb.sh is now dynamically generated. But running the build commands directly still doesn't pick up all configure arguments:

$ ./configure --enable-apparmor --disable-firetunnel
$ make deb

That produces a deb with firetunnel support enabled:

$ firejail --version
firejail version 0.9.63

Compile time support:
        - AppArmor support is enabled
        - AppImage support is enabled
        - chroot support is enabled
        - file and directory whitelisting support is enabled
        - file transfer support is enabled
        - firetunnel support is enabled
        - networking support is enabled
        - overlayfs support is enabled
        - private-home support is enabled
        - seccomp-bpf support is enabled
        - SELinux support is disabled
        - user namespace support is enabled
        - X11 sandboxing support is enabled

Could the dynamic generation of mkdeb.sh please take custom configure options into account?
Or is that still not possible, so fj-mkdeb.py needs to be updated?
@rusty-snake
Copy link
Collaborator

Could the dynamic generation of mkdeb.sh please take custom configure options into account?

It does. The error says something else. It should work with.

$ ./configure
$ ./contrib/fj-mkdeb.py --enable-apparmor --disable-firetunnel

@laniakea64
Copy link
Contributor Author

Unfortunately that still doesn't work -

$ firejail --version
firejail version 0.9.63

Compile time support:
        - AppArmor support is enabled
        - AppImage support is enabled
        - chroot support is enabled
        - file and directory whitelisting support is enabled
        - file transfer support is enabled
        - firetunnel support is enabled
        - networking support is enabled
        - overlayfs support is enabled
        - private-home support is enabled
        - seccomp-bpf support is enabled
        - SELinux support is disabled
        - user namespace support is enabled
        - X11 sandboxing support is enabled

@rusty-snake
Copy link
Collaborator

But the error is gone? If not try to use --fj-src to workaround.

@laniakea64
Copy link
Contributor Author

But the error is gone?

Yes it built without error. But as the output above shows, my configure options were still ignored.

Maybe it would help clarify the problem to link the longer back story? - #772

I still don't know the reasoning behind #772 (comment) . Now that mkdeb.sh is dynamically generated, does that reasoning still apply?

@rusty-snake
Copy link
Collaborator

I can't test it, because I have no debian, but this generates a mkdeb.sh with ./configure --prefix=/usr --enable-apparmor --disable-firetunnel:
./configure && ./contrib/fj-mkdeb.py --only-fix-mkdeb --enable-apparmor --disable-firetunnel

@Fred-Barclay
Copy link
Collaborator

I can't test it, because I have no debian...

Tested and it works on my end:

$ firejail --version
firejail version 0.9.63

Compile time support:
        - AppArmor support is enabled
        - AppImage support is enabled
        - chroot support is enabled
        - file and directory whitelisting support is enabled
        - file transfer support is enabled
        - firetunnel support is disabled
        - networking support is enabled
        - overlayfs support is enabled
        - private-home support is enabled
        - seccomp-bpf support is enabled
        - SELinux support is disabled
        - user namespace support is enabled
        - X11 sandboxing support is enabled

@laniakea64
Copy link
Contributor Author

I can't test it, because I have no debian, but this generates a mkdeb.sh with ./configure --prefix=/usr --enable-apparmor --disable-firetunnel:
./configure && ./contrib/fj-mkdeb.py --only-fix-mkdeb --enable-apparmor --disable-firetunnel

Thanks @rusty-snake for the workaround, it works for me too:

./configure && ./contrib/fj-mkdeb.py --only-fix-mkdeb --enable-apparmor --disable-firetunnel && make deb

@laniakea64
Copy link
Contributor Author

So will there be first-class availability of custom configure options for .deb build? Or does fj-mkdeb.py need to be patched based on the workaround above?

@laniakea64
Copy link
Contributor Author

So will there be first-class availability of custom configure options for .deb build? Or does fj-mkdeb.py need to be patched based on the workaround above?

I ask because if there still cannot be first-class availability of custom configure options for .deb build, I am the original author of fj-mkdeb.py and would try to look into updating it.

@rusty-snake
Copy link
Collaborator

I see no reason why fj-mkdeb.py should not have a option for that.

@laniakea64 laniakea64 mentioned this issue Sep 3, 2020
Merged
kmk3 added a commit to kmk3/firejail that referenced this issue May 20, 2022
@kmk3
mkdeb.sh.in: stop running ./configure
6dd0b8d 
On firejail 0.9.68, one would run `./configure` (to generate Makefile
from Makefile.in) and then running `make deb` would end up running
something akin to:

    make distclean && make dist && ./configure --prefix=/usr && mkdeb.sh

As of netblue30#5142, `make dist` does not run `make distclean` anymore, but
`make deb` still overrides any configure options that the user might
have set.

Stop doing that and do just `make dist && mkdeb.sh` on `make deb`.

To build everything from scratch as `make deb` would do on 0.9.68 (but
without it overriding the configure options), one can run:

    make distclean && ./configure --prefix=/usr && make deb

Note that this is basically what the "build_debian_package" job on
.gitlab-ci.yml does (see also the "build_apparmor" job).

Should fully fix netblue30#3523.

Relates to netblue30#772 netblue30#1205.
kmk3 added a commit to kmk3/firejail that referenced this issue May 20, 2022
@kmk3
mkdeb.sh.in: stop running ./configure
d6df053 
On firejail 0.9.68, one would run `./configure` (to generate Makefile
from Makefile.in) and then running `make deb` would end up running
something akin to:

    make distclean && make dist && ./configure --prefix=/usr &&
      ./mkdeb.sh

As of netblue30#5142, `make dist` does not run `make distclean` anymore, but
`make deb` still overrides any configure options that the user might
have set.

Stop doing that and do just `make dist && ./mkdeb.sh` on `make deb`.

To build everything from scratch as `make deb` would do on 0.9.68 (but
without it overriding the configure options), one can run:

    make distclean && ./configure --prefix=/usr && make deb

Note that this is basically what the "build_debian_package" job on
.gitlab-ci.yml does (see also the "build_apparmor" job).

Should fully fix netblue30#3523.

Relates to netblue30#772 netblue30#1205.
@kmk3 kmk3 mentioned this issue May 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update fj-mkdeb.py
3 participants
@Fred-Barclay @laniakea64 @rusty-snake