Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI seems broken, unsure on how to proceed. #3928

Closed
glitsj16 opened this issue Jan 30, 2021 · 4 comments · Fixed by #3929
Closed

CI seems broken, unsure on how to proceed. #3928

glitsj16 opened this issue Jan 30, 2021 · 4 comments · Fixed by #3929

Comments

@glitsj16
Copy link
Collaborator

glitsj16 commented Jan 30, 2021

I'm seeing Build CI / build_and_test (pull_request) failures in the last 2 PR's (#3924 and #3926). The PR's in question seem to be rather straightforward profile changes and I'm not familiar enough with that part of the process to easilly spot what could be wrong by looking at the CI logs. Just putting this out here to bring it to the attention of more experienced collaborators.

Personally I think it's wise to temporarily stop merging until the CI situation clears up, no matter how irritating this could be for people wanting to contribute.

@rusty-snake
Copy link
Collaborator

Since 7c1dae0 every BuildCI fails (sort.py continues to work). But I don't understand how this is possible. I already searched for telegram, error, fail in the logs, but I saw nothing relevant.

@rusty-snake
Copy link
Collaborator

I just re-run the BuildCI for f806d34 (the last commit where is passed) and it failed. Seems to be caused by a cahnge in GitHub Actions?

@reinerh
Copy link
Collaborator

reinerh commented Jan 30, 2021

One of the tests related to sound is now failing. No idea why it was working before, or why it's now failing:

TESTING: sound (test/environment/sound.exp)
spawn /bin/bash
firejail --nosound speaker-test
runner@fv-az102-903:~/work/firejail/firejail/test/environment$ 
<l/test/environment$ firejail --nosound speaker-test           �����������
Reading profile /etc/firejail/default.profile
Reading profile /etc/firejail/disable-common.inc
Reading profile /etc/firejail/disable-passwdmgr.inc
Reading profile /etc/firejail/disable-programs.inc

** Note: you can use --noprofile to disable default.profile **

Parent pid 9947, child pid 9948
Warning: cleaning all supplementary groups
�]0;firejail speaker-test �Child process initialized in 63.87 ms

speaker-test 1.2.2

Playback device is default
Stream parameters are 48000Hz, S16_LE, 1 channels
Using 16 octaves of pink noise
ALSA lib confmisc.c:767:(parse_card) cannot find card '0'
ALSA lib conf.c:4732:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
ALSA lib conf.c:4732:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
ALSA lib confmisc.c:1246:(snd_func_refer) error evaluating name
ALSA lib conf.c:4732:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5220:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2642:(snd_pcm_open_noupdate) Unknown PCM default
Playback open error: -2,No such file or directory

Parent is shutting down, bye...
runner@fv-az102-903:~/work/firejail/firejail/test/environment$ 
<ejail/test/environment$ firejail --nosound aplay -l           �����������
Reading profile /etc/firejail/default.profile
Reading profile /etc/firejail/disable-common.inc
Reading profile /etc/firejail/disable-passwdmgr.inc
Reading profile /etc/firejail/disable-programs.inc

** Note: you can use --noprofile to disable default.profile **

Parent pid 9953, child pid 9954
Warning: cleaning all supplementary groups
�]0;firejail aplay -l �Child process initialized in 63.01 ms
aplay: device_list:274: no soundcards found...

Parent is shutting down, bye...
runner@fv-az102-903:~/work/firejail/firejail/test/environment$ 
<ment$ firejail --profile=sound.profile speaker-test           �����������
Reading profile sound.profile
Parent pid 9959, child pid 9960
�]0;firejail speaker-test �Child process initialized in 7.35 ms

speaker-test 1.2.2

Playback device is default
Stream parameters are 48000Hz, S16_LE, 1 channels
Using 16 octaves of pink noise
ALSA lib confmisc.c:767:(parse_card) cannot find card '0'
ALSA lib conf.c:4732:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
ALSA lib conf.c:4732:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
ALSA lib confmisc.c:1246:(snd_func_refer) error evaluating name
ALSA lib conf.c:4732:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5220:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2642:(snd_pcm_open_noupdate) Unknown PCM default
Playback open error: -2,No such file or directory

Parent is shutting down, bye...
runner@fv-az102-903:~/work/firejail/firejail/test/environment$ 
<ironment$ firejail --profile=sound.profile aplay -l           �����������
Reading profile sound.profile
Parent pid 9963, child pid 9964
�]0;firejail aplay -l �Child process initialized in 6.78 ms
aplay: device_list:274: no soundcards found...

Parent is shutting down, bye...
runner@fv-az102-903:~/work/firejail/firejail/test/environment$ 
<rejail/firejail/test/environment$ firejail aplay -l           �����������
Reading profile /etc/firejail/default.profile
Reading profile /etc/firejail/disable-common.inc
Reading profile /etc/firejail/disable-passwdmgr.inc
Reading profile /etc/firejail/disable-programs.inc

** Note: you can use --noprofile to disable default.profile **

Parent pid 9968, child pid 9969
Warning: cleaning all supplementary groups
�]0;firejail aplay -l �Child process initialized in 49.88 ms
aplay: device_list:274: no soundcards found...

Parent is shutting down, bye...
runner@fv-az102-903:~/work/firejail/firejail/test/environment$ TESTING ERROR 24

@reinerh
Copy link
Collaborator

reinerh commented Jan 30, 2021

In environment.sh there is a check if aplay exists. Only then this test is actually run.
Maybe the github CI environment now contains aplay (even though there is no soundcard), so the test fails.
I'll improve the check.

reinerh added a commit that referenced this issue Jan 30, 2021
reinerh added a commit that referenced this issue Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants