Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firecfg: Support OpenDoas #5899

Closed
ghost opened this issue Jul 14, 2023 · 3 comments · Fixed by #5900
Closed

firecfg: Support OpenDoas #5899

ghost opened this issue Jul 14, 2023 · 3 comments · Fixed by #5900
Labels
enhancement New feature request firecfg Anything related to firecfg and not firejail itself

Comments

@ghost
Copy link

ghost commented Jul 14, 2023

Is your feature request related to a problem? Please describe.

There was a somewhat recent security vulnerability in sudo leading some users (myself included) to look into projects such as OpenDoas, which is a simpler and easier to audit way of handling privilege escalation that I and some other users in the GNU/Linux community have migrated to. Firecfg does NOT function properly using doas to run, it explicitly requires sudo. When attempting to use doas, it will act as though firecfg was run as the root user, and not as a heightened-privilege user similar to sudo.

Describe the solution you'd like

Perhaps adding an option similar to paru's config file that easily allows Firecfg to be run in "doas mode."

Describe alternatives you've considered

I am not entirely sure if this is something doas is capable of accomplishing, as it is intentionally left as simple as possible. But, I do believe a workaround can be made. I am not a programmer, I'd love to make a pull request if I knew how to add such a feature. 😅

Additional context

Any response is appreciated. :)

@kmk3 kmk3 added the enhancement New feature request label Jul 14, 2023
kmk3 added a commit to kmk3/firejail that referenced this issue Jul 14, 2023
@kmk3 kmk3 added the firecfg Anything related to firecfg and not firejail itself label Jul 14, 2023
@rusty-snake
Copy link
Collaborator

OT: Duncaen/OpenDoas#106


Assuming you use doas, can you run doas printenv | grep DOAS_USER and report back if it prints your user.

If so it is a simple second check in

char *user = getenv("SUDO_USER");
and
char *get_sudo_user(void) {
.

@rusty-snake
Copy link
Collaborator

Nevermind @kmk3 has already done in #5900.

@kmk3
Copy link
Collaborator

kmk3 commented Jul 16, 2023

@shaggonit Done in #5900, thanks for the suggestion.

kmk3 added a commit that referenced this issue Jul 19, 2023
@kmk3 kmk3 changed the title [Firecfg] Support OpenDoas firecfg: Support OpenDoas Aug 18, 2024
@kmk3 kmk3 moved this to Done (on RELNOTES) in Release 0.9.74 Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request firecfg Anything related to firecfg and not firejail itself
Projects
Status: Done (on RELNOTES)
Development

Successfully merging a pull request may close this issue.

2 participants