-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
private-bin breaks --join for filezilla #2633
Conversation
what is your default shell? zsh? fish? |
you're right, my bad; that didn't even cross my mind. |
hmm, I think at one point if |
could something maybe be done with the $SHELL variable? |
On my System sh is a symlink to bash, but my user default shell is zsh. |
Here is the deal with private-bin. The ugliest executable you can add on this line is a shell. An attacker after getting control of the program will want to start a shell session on your computer. If there is no shell available, bad luck! For various reasons, a small number of programs are using an external shell, usually /bin/sh. Some of them might even go after $SHELL env variable. In the case of filezilla, we already know it is using /bin/bash, so the damage is already done. I don't see any reason not to add zsh on that line. @veloute if you just add zsh on private-bin line, is it working? |
yes, joining works after adding zsh to private-bin. |
ok, let's go for adding zsh on the private-bin line - I'll check it in in a few minutes |
I guess every other profile with |
Let's wait for people to start complaining about it. |
i think i'm ready to complain about it :P |
perhaps there's another solution, but this is the only fix i could find for fixing --join.
error i get: