Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up for #3326 #3397

Merged
merged 3 commits into from
May 4, 2020
Merged

Follow-up for #3326 #3397

merged 3 commits into from
May 4, 2020

Conversation

glitsj16
Copy link
Collaborator

@glitsj16 glitsj16 commented May 3, 2020

Purely cosmetic stuff, no functional changes.

Now that #3326 landed I think it might be less confusing to keep using the --nodbus wording. Couldn't come up with a better alternative (yet), so this might need future improvements.
@@ -40,5 +39,9 @@ disable-mnt
?BROWSER_DISABLE_U2F: private-dev
# private-tmp - problems with multiple browser sessions

# prevents access to passwords saved in GNOME Keyring and KWallet, also breaks Gnome connector
# dbus-user none
# dbus-system none
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we block the system-bus?

Copy link
Collaborator Author

@glitsj16 glitsj16 May 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rusty-snake Not sure, I'm actually not that familiar with chrome-based browsers. So if you say the system bus can be blocked without users being unable to save passwords etc. I'm totally ok with that. Thanks for the input, I didn't want to commit this without seeking some advice.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Password are per user, therefore on the session-bus.

In general: I block the system-bus in my pre-globals.local for around two month now, and only allowed it for d-feet and searhorse. IHMO we can add dbus-system none to the most profiles.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I'm not sure if it maybe still breaks something in chromium.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rusty-snake That makes sense, thanks for your input, as always. I've blocked the system bus, we can change this later if we get issue reports.

Blocking the system bus shouldn't affect password functionality etc, as that uses the session bus.
@glitsj16 glitsj16 merged commit 276f250 into netblue30:master May 4, 2020
@glitsj16 glitsj16 deleted the dbus branch May 4, 2020 18:48
@matu3ba matu3ba mentioned this pull request Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants