Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add element-desktop redirect profile #3517

Merged
merged 4 commits into from
Jul 16, 2020
Merged

add element-desktop redirect profile #3517

merged 4 commits into from
Jul 16, 2020

Conversation

glitsj16
Copy link
Collaborator

This PR accomodates the name change from Riot to Element.

@glitsj16 glitsj16 merged commit ad12d90 into netblue30:master Jul 16, 2020
@glitsj16 glitsj16 deleted the element-desktop branch July 16, 2020 22:32
@bbhtt
Copy link
Contributor

bbhtt commented Jul 17, 2020

How are you escaping the "(...)" in pathname?

@rusty-snake
Copy link
Collaborator

Why escaping?

@bbhtt
Copy link
Contributor

bbhtt commented Jul 17, 2020

Profile doesn't work in 0.9.62 was support included in 0.9.63?

@rusty-snake
Copy link
Collaborator

() is allowed since #3156.

@glitsj16
Copy link
Collaborator Author

Profile doesn't work in 0.9.62 was support included in 0.9.63?

@kortewegdevries The name change was only introduced a few days ago, on July 15, so it's normal that you don't have this profile in 0.9.62. As @rusty-snake pointed out, there have been other changes that might explain why you can't run this in 0.9.62. Or are you testing with firejail from git and are experiencing issues?

@bbhtt
Copy link
Contributor

bbhtt commented Jul 17, 2020

No thanks, it works under current git. I was building a profile myself and I wasn't able to figure out how special characters were included in pathname.

@eighthave
Copy link
Contributor

I tried this with 0.9.62, and got:

$ /usr/bin/firejail /opt/Element/element-desktop
Reading profile /etc/firejail/element-desktop.profile
Error: "/.config/Element (Riot)" is an invalid filename
$ sed -i 's,\${HOME},/home/eighthave,g' /etc/firejail/element-desktop.profile
$ /usr/bin/firejail /opt/Element/element-desktop
Reading profile /etc/firejail/element-desktop.profile
Error: "/home/eighthave/.config/Element (Riot)" is an invalid filename
$

This seems to be triggered by noblacklist

@rusty-snake
Copy link
Collaborator

@eighthave this is not supported in 0.9.62. Read the comments above.

@bbhtt
Copy link
Contributor

bbhtt commented Jul 28, 2020

Note that this folder: ${HOME}/.config/Element (Riot) isn't created any more after today's update,as far as I know. Someone in ArchLinux room said and I checked.

@glitsj16
Copy link
Collaborator Author

Note that this folder: ${HOME}/.config/Element (Riot) isn't created any more after today's update,as far as I know.

@kortewegdevries Thanks for the info. I'll check what's used on other OS'es and will drop it accordingly. If you want to get rid of it right now, you can always blacklist / nowhitelist ${HOME}/.config/Element (Riot) in a local override file.

glitsj16 added a commit that referenced this pull request Nov 22, 2020
Cfr. #3517 (comment): element-desktop no longer uses ${HOME}/.config/Element (Riot).
@matu3ba matu3ba mentioned this pull request Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants