Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New profile for homebank #3525

Merged
merged 11 commits into from
Jul 21, 2020
Merged

New profile for homebank #3525

merged 11 commits into from
Jul 21, 2020

Conversation

bbhtt
Copy link
Contributor

@bbhtt bbhtt commented Jul 19, 2020

New profile for homebank
Copy link
Collaborator

@rusty-snake rusty-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add it to src/firecfg/firecfg.config.

etc/profile-a-l/homebank.profile Outdated Show resolved Hide resolved
etc/profile-a-l/homebank.profile Show resolved Hide resolved
etc/profile-a-l/homebank.profile Outdated Show resolved Hide resolved
etc/profile-a-l/homebank.profile Outdated Show resolved Hide resolved
etc/profile-a-l/homebank.profile Outdated Show resolved Hide resolved
etc/profile-a-l/homebank.profile Show resolved Hide resolved
bbhtt and others added 3 commits July 19, 2020 18:19
Co-authored-by: rusty-snake <41237666+rusty-snake@users.noreply.github.com>
Co-authored-by: rusty-snake <41237666+rusty-snake@users.noreply.github.com>
@bbhtt
Copy link
Contributor Author

bbhtt commented Jul 19, 2020

Add it to src/firecfg/firecfg.config.

Oops I forgot about that. If we don't want to read the docs, might as well remove the extra whitelists?

@bbhtt bbhtt requested a review from rusty-snake July 19, 2020 13:23
etc/inc/disable-programs.inc Outdated Show resolved Hide resolved
etc/profile-a-l/homebank.profile Show resolved Hide resolved
etc/profile-a-l/homebank.profile Outdated Show resolved Hide resolved
Added disable-shell,removed whitelisted docs
@bbhtt bbhtt requested a review from rusty-snake July 19, 2020 16:02
Changed sorting
@svc88
Copy link

svc88 commented Jul 19, 2020

With the current https://github.com/netblue30/firejail/blob/7ae6c0a90b2db59effe1ad1d62dbcec431069be6/etc/profile-a-l/homebank.profile on my current v0.9.62 i get Error: cannot access profile file: disable-shell.inc
Any idea if im missing anything here?

@rusty-snake
Copy link
Collaborator

No, disable-shell.inc was added it 0.9.63.

@svc88
Copy link

svc88 commented Jul 19, 2020

No, disable-shell.inc was added it 0.9.63.

oh ok, how can i make this profile compatible with 0.9.62 ?

@rusty-snake
Copy link
Collaborator

Copy disable-shell.inc from git (it works in 0.9.62 too) or comment its include.

@svc88
Copy link

svc88 commented Jul 19, 2020

Copy disable-shell.inc from git (it works in 0.9.62 too) or comment its include.

ok i tried both ways you said but in both ways it complains
Error: cannot access profile file: whitelist-runuser-common.inc

Should this also be copied to 0.9.62 ?

Edit Update:
I also copied over whitelist-runuser-common.inc and now it complains:
Error: line 56 in /usr/local/etc/firejail/homebank.profile is invalid

@bbhtt
Copy link
Contributor Author

bbhtt commented Jul 19, 2020

@svc88 This should work for 0.9.62: homebank.profile

@rusty-snake
Copy link
Collaborator

rusty-snake commented Jul 19, 2020

Should this also be copied to 0.9.62 ?

You can, it may breaks XWayland under GNOME. However homebank uses GTK so it uses Wayland if possible.

and now it complains:

0.9.62 is about a half year old. There were some change as you see. For this comment dbus-* none and add nodbus.

edit: @kortewegdevries was faster.

@bbhtt
Copy link
Contributor Author

bbhtt commented Jul 21, 2020

Was trying to push to my testing,ended up here,sorry.

@rusty-snake rusty-snake merged commit 30927eb into netblue30:master Jul 21, 2020
@rusty-snake
Copy link
Collaborator

Merged, Thanks.

@matu3ba matu3ba mentioned this pull request Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants