Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vmware profile #3526

Closed
wants to merge 93 commits into from
Closed

Add vmware profile #3526

wants to merge 93 commits into from

Conversation

Neo00001
Copy link
Collaborator

No description provided.

@Neo00001 Neo00001 changed the title vmware profile Add vmware profile Jul 19, 2020
Copy link
Collaborator

@rusty-snake rusty-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODOs:

  • Header (see the profile template)~
  • whitelisting goes in a block between the disable-.inc and caps.
  • ${HOME}/.vmware and ${HOME}/.cache/vmware need a mkdir and noblacklist + a blacklist in disable-programs.inc
  • nodbus should be removed, since it is deprecated as of 0.9.63. Move the dbus-* none command in a extra block at the end of the file
  • The blank lines between disable-mnt ant private-etc can be removed.
  • ipc-namespace should be removed
  • caps.drop all can be removed

What about:

  • whitelist-usr-share-common.inc
  • whitelist-var-common.inc
  • whitelist-runuser-common.inc
  • nonewprivs (may break?)
  • noroot
  • tracelog
  • protocol
  • seccomp
  • private-cache
  • private-dev (does this allow /dev/kvm?)
  • private-bin
  • private-tmp

@Neo00001
Copy link
Collaborator Author

Neo00001 commented Jul 19, 2020

whitelist-usr-share-common.inc,whitelist-var-common.inc,whitelist-runuser-common.inc

  • didn't feel the need. nothing seems broken regarding normal functionality. btw, whitelist-runuser-common.inc is not available under firejail version 0.9.62.

nonewprivs,noroot,protocol,seccomp,private-bin

  • all of these make vmware dysfunctional. vmware may launch but can't run any guest os.

private-bin

  • despite allowing all of vmware related bin files vmware still doesn't run. if you may suggest some other files I would like to check it further.

private-cache

  • drag & drop from guest to host won't work

private-tmp

  • it may work, I have to check it though. there is a folder namely VMwareDnD (in /tmp) which keeps linked folders of cache's drag_and_drop folder's contents.

tracelog

  • it works. but is it needed?

@rusty-snake
Copy link
Collaborator

didn't feel the need. nothing seems broken regarding normal functionality

Adding them is more secure, then are only whitelisted files/dirs allowed, w/o all are allowed.
wusc may need extras (e.g. whitelist /usr/share/vm-ware)

all of these make vmware dysfunctional. vmware may launch but can't run any guest os.

👍 vmware is a suid, right?

  • protocol which what protocols have tested? protocol unix,inet,inet6,netlink,packet is the most permissive one.
  • seccomp you can watch your syslog (journalctl --follow) to know which syscall are blocked

despite allowing all of vmware related bin files vmware still doesn't run. if you may suggest some other files I would like to check it further.

You can use firejail --build vmware You can not since nonewprivs breaks.

it works. but is it needed?

It logs blacklist violation which are usually a indicator for issues. In general it is added to all profiles where it is supported.

whitelist-runuser-common.inc is not available under firejail version 0.9.62.

If you still use X11, you can copy it.

etc/profile-m-z/vmware.profile Outdated Show resolved Hide resolved
etc/profile-m-z/vmware.profile Outdated Show resolved Hide resolved
etc/profile-m-z/vmware.profile Outdated Show resolved Hide resolved
etc/profile-m-z/vmware.profile Outdated Show resolved Hide resolved
etc/profile-m-z/vmware.profile Show resolved Hide resolved
@Neo00001
Copy link
Collaborator Author

Neo00001 commented Jul 19, 2020

private-tmp is breaking drag & drop from guest to host.

Everything got copied twice.

Neo00001 and others added 5 commits July 19, 2020 18:58
Co-authored-by: rusty-snake <41237666+rusty-snake@users.noreply.github.com>
Co-authored-by: rusty-snake <41237666+rusty-snake@users.noreply.github.com>
Co-authored-by: rusty-snake <41237666+rusty-snake@users.noreply.github.com>
Co-authored-by: rusty-snake <41237666+rusty-snake@users.noreply.github.com>
@Neo00001
Copy link
Collaborator Author

Neo00001 commented Jul 19, 2020

  • protocol which what protocols have tested? protocol unix,inet,inet6,netlink,packet is the most permissive one.

  • seccomp you can watch your syslog (journalctl --follow) to know which syscall are blocked

protocol unix,inet,inet6,netlink,packet

  • doesn't allow vmware to run any guest os.

& regarding seccomp, the syscall was iopl. & seccomp !iopl doesn't work

@rusty-snake
Copy link
Collaborator

It maybe more then one, if seccomp !foo,!bar breaks without any logs, you can leave it out.

@Neo00001
Copy link
Collaborator Author

It maybe more then one, if seccomp !foo,!bar breaks without any logs, you can leave it out.

seccomp !iopl breaks without logs.

@Neo00001
Copy link
Collaborator Author

should I add nou2f?

rusty-snake pushed a commit to rusty-snake/firejail that referenced this pull request Jul 30, 2020
Squashed commit of the following:

commit 8f67c5df5435ed3e562c1888678b0f6de964be86
Author: Neo00001 <40570803+Neo00001@users.noreply.github.com>
Date:   Wed Jul 22 23:50:40 2020 +0000

    Update vmware.profile

commit 88f0bbda8d66ef1977b9ad6a616320bc37912fe3
Author: Neo00001 <40570803+Neo00001@users.noreply.github.com>
Date:   Wed Jul 22 16:47:38 2020 +0000

    Update vmware.profile

commit 18d19324a56e1031b69e0de2f01fb6082b653871
Author: Neo00001 <40570803+Neo00001@users.noreply.github.com>
Date:   Wed Jul 22 15:47:00 2020 +0000

    Update vmware.profile

commit de5227ffc0d5dbcd632acffc2411c57d89ca857a
Author: Neo00001 <40570803+Neo00001@users.noreply.github.com>
Date:   Wed Jul 22 15:37:22 2020 +0000

    Update vmware.profile

commit 0495a766f5c3af746887b48d66652631d8cbc6a2
Author: Neo00001 <40570803+Neo00001@users.noreply.github.com>
Date:   Wed Jul 22 15:34:54 2020 +0000

    Update vmware.profile

commit e2964691b0fd3fcf3887c7cbbed9c03ad50dc1e6
Author: Neo00001 <40570803+Neo00001@users.noreply.github.com>
Date:   Mon Jul 20 14:50:58 2020 +0000

    Update vmware.profile

commit 5a408097577aaed94e1da9462b8864384d236726
Author: Neo00001 <40570803+Neo00001@users.noreply.github.com>
Date:   Mon Jul 20 12:34:23 2020 +0000

    Update vmware.profile

commit c3f7bdf048898de266e3eb99d2981110e9a51738
Author: Neo00001 <40570803+Neo00001@users.noreply.github.com>
Date:   Mon Jul 20 12:07:42 2020 +0000

    Update vmware.profile

commit 4a9d85d25da909fcf2b6a53b233064ea8b4dce8f
Author: Neo00001 <40570803+Neo00001@users.noreply.github.com>
Date:   Sun Jul 19 22:50:22 2020 +0000

    Update vmware.profile

commit cd3e67c739b0415fb38e13aefecef917edeca79f
Author: Neo00001 <40570803+Neo00001@users.noreply.github.com>
Date:   Sun Jul 19 22:13:14 2020 +0000

    Update vmware.profile

commit fe1005365486d4a7d7c3dca917f6a4d743a173f1
Author: Neo00001 <40570803+Neo00001@users.noreply.github.com>
Date:   Sun Jul 19 19:08:45 2020 +0000

    Update vmware.profile

commit 068350620ce7b14c65b2b0f71fe3048dfbd7c920
Author: Neo00001 <40570803+Neo00001@users.noreply.github.com>
Date:   Sun Jul 19 19:06:01 2020 +0000

    Update vmware.profile

commit 6d7811f2836b9786ee7cd23626a0dbe92e880d81
Author: Neo00001 <40570803+Neo00001@users.noreply.github.com>
Date:   Sun Jul 19 19:01:01 2020 +0000

    Update vmware.profile

commit d588b8e36c85821279ccd7427fcde5ddb7bf5ad8
Author: Neo00001 <40570803+Neo00001@users.noreply.github.com>
Date:   Sun Jul 19 18:59:41 2020 +0000

    Update etc/profile-m-z/vmware.profile

    Co-authored-by: rusty-snake <41237666+rusty-snake@users.noreply.github.com>

commit 92853797a5325f39d88f5890deb604830217be42
Author: Neo00001 <40570803+Neo00001@users.noreply.github.com>
Date:   Sun Jul 19 18:59:21 2020 +0000

    Update etc/profile-m-z/vmware.profile

    Co-authored-by: rusty-snake <41237666+rusty-snake@users.noreply.github.com>

commit 7e7def1cfdb80267492143b335e7aefb289a3cff
Author: Neo00001 <40570803+Neo00001@users.noreply.github.com>
Date:   Sun Jul 19 18:59:09 2020 +0000

    Update etc/profile-m-z/vmware.profile

    Co-authored-by: rusty-snake <41237666+rusty-snake@users.noreply.github.com>

commit 4259b8c366444b058d4f24dfbae163e58828d068
Author: Neo00001 <40570803+Neo00001@users.noreply.github.com>
Date:   Sun Jul 19 18:58:58 2020 +0000

    Update etc/profile-m-z/vmware.profile

    Co-authored-by: rusty-snake <41237666+rusty-snake@users.noreply.github.com>

commit 4c40c9dd142977d7866a6e1d8c23dc1e198e8c2c
Author: Neo00001 <40570803+Neo00001@users.noreply.github.com>
Date:   Sun Jul 19 18:42:51 2020 +0000

    Update disable-programs.inc

commit 12eba38bb1bc12fb420a2004d5f71773cad40e53
Author: Neo00001 <40570803+Neo00001@users.noreply.github.com>
Date:   Sun Jul 19 18:30:52 2020 +0000

    Update vmware.profile

commit e30f8754a8f47309757f0baf28cba7d2f85c7940
Author: Neo00001 <40570803+Neo00001@users.noreply.github.com>
Date:   Sun Jul 19 18:05:56 2020 +0000

    Update vmware.profile

commit bece3239aba73741644e13d6ed53807faee33bf4
Author: Neo00001 <40570803+Neo00001@users.noreply.github.com>
Date:   Sun Jul 19 16:28:48 2020 +0000

    Create vmware.profile

commit e92417713bf20d8415a834c57ce6b04326dc2b80
Author: Neo00001 <40570803+Neo00001@users.noreply.github.com>
Date:   Sun Jul 19 16:13:45 2020 +0000

    Update firecfg.config
rusty-snake pushed a commit to rusty-snake/firejail that referenced this pull request Jul 30, 2020
@rusty-snake
Copy link
Collaborator

Reseted, rebased and squashed that for you. Merged in 6fa68d1.

PS: You should delete your fork and fork again.

@Neo00001
Copy link
Collaborator Author

Reseted, rebased and squashed that for you. Merged in 6fa68d1.

PS: You should delete your fork and fork again.

Thanks.

& Sorry for all of these.

@matu3ba matu3ba mentioned this pull request Oct 7, 2021
kmk3 added a commit to kmk3/firejail that referenced this pull request Jun 20, 2023
kmk3 added a commit to kmk3/firejail that referenced this pull request Jun 20, 2023
As a redirect to vmware.profile.

This is apparently the filename for the "VMWare Workstation Player" on
Linux Mint 20.3 (based on Ubuntu 20.04).

Relates to netblue30#3526.

Reported by @MikeNavy in netblue30#5861.
kmk3 added a commit to kmk3/firejail that referenced this pull request Jun 21, 2023
kmk3 added a commit to kmk3/firejail that referenced this pull request Jun 21, 2023
As a redirect to vmware.profile.

This is apparently the filename for the "VMWare Workstation Player" on
Linux Mint 20.3 (based on Ubuntu 20.04)[1].

Relates to netblue30#3526.

[1] netblue30#5861 (comment)

Reported-by: @MikeNavy
kmk3 added a commit to kmk3/firejail that referenced this pull request Jun 21, 2023
It apparently fails on Linux Mint 20.3 (based on Ubuntu 20.04) due to
the "VMWare Kernel Module Updater" being unable to find gcc[1].

Relates to netblue30#3526.

[1] netblue30#5861 (comment)

Reported-by: @MikeNavy
kmk3 added a commit to kmk3/firejail that referenced this pull request Jun 21, 2023
They appear to be broken on Linux Mint 20.3 (based on Ubuntu 20.04), due
to the "VMWare Kernel Module Updater" being unable to install kernel
modules[1].

Relates to netblue30#3526.

[1] netblue30#5861 (comment)

Reported-by: @MikeNavy
kmk3 added a commit to kmk3/firejail that referenced this pull request Jun 21, 2023
kmk3 added a commit to kmk3/firejail that referenced this pull request Jun 21, 2023
As a redirect to vmware.profile.

This is apparently the filename for the "VMWare Workstation Player" on
Linux Mint 20.3 (based on Ubuntu 20.04)[1].

Relates to netblue30#3526.

[1] netblue30#5861 (comment)

Reported-by: @MikeNavy
kmk3 added a commit to kmk3/firejail that referenced this pull request Jun 21, 2023
It apparently fails on Linux Mint 20.3 (based on Ubuntu 20.04) due to
the "VMWare Kernel Module Updater" being unable to find gcc[1].

Relates to netblue30#3526.

[1] netblue30#5861 (comment)

Reported-by: @MikeNavy
kmk3 added a commit to kmk3/firejail that referenced this pull request Jun 21, 2023
They appear to be broken on Linux Mint 20.3 (based on Ubuntu 20.04), due
to the "VMWare Kernel Module Updater" being unable to install kernel
modules[1].

Relates to netblue30#3526.

[1] netblue30#5861 (comment)

Reported-by: @MikeNavy
kmk3 added a commit to kmk3/firejail that referenced this pull request Jun 21, 2023
kmk3 added a commit to kmk3/firejail that referenced this pull request Jun 21, 2023
As a redirect to vmware.profile.

This is apparently the filename for the "VMWare Workstation Player" on
Linux Mint 20.3 (based on Ubuntu 20.04)[1].

Relates to netblue30#3526.

[1] netblue30#5861 (comment)

Reported-by: @MikeNavy
kmk3 added a commit to kmk3/firejail that referenced this pull request Jun 21, 2023
It apparently fails on Linux Mint 20.3 (based on Ubuntu 20.04) due to
the "VMWare Kernel Module Updater" being unable to find gcc[1].

Relates to netblue30#3526.

[1] netblue30#5861 (comment)

Reported-by: @MikeNavy
kmk3 added a commit to kmk3/firejail that referenced this pull request Jun 21, 2023
It appears to be broken on Linux Mint 20.3 (based on Ubuntu 20.04), due
to the "VMWare Kernel Module Updater" being unable to install kernel
modules[1].

Relates to netblue30#3526.

[1] netblue30#5861 (comment)

Reported-by: @MikeNavy
@kmk3 kmk3 mentioned this pull request Jun 21, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants