Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various profiles #3561

Merged
merged 2 commits into from
Sep 2, 2020
Merged

Various profiles #3561

merged 2 commits into from
Sep 2, 2020

Conversation

bbhtt
Copy link
Contributor

@bbhtt bbhtt commented Jul 30, 2020

No description provided.

Copy link
Collaborator

@rusty-snake rusty-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes to go through.

etc/inc/disable-programs.inc Outdated Show resolved Hide resolved
etc/profile-a-l/kazam.profile Show resolved Hide resolved
etc/profile-a-l/kazam.profile Show resolved Hide resolved
etc/profile-m-z/menulibre.profile Outdated Show resolved Hide resolved
etc/profile-m-z/menulibre.profile Outdated Show resolved Hide resolved
include disable-passwdmgr.inc
include disable-xdg.inc

include whitelist-runuser-common.inc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wusc?

whitelist?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Half of the list is not being populated with desktop entries, tried adding whitelist /usr/share/applications
whitelist /usr/share/menulibre with wusc.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works the following? If not try with --build. If thats still don't work, leave it.

whitelist /usr/share/applications
whitelist /usr/share/menulibre
whitelist /usr/share/desktop-directories
include wusc.inc

Copy link
Contributor Author

@bbhtt bbhtt Jul 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works,thanks but some of the entries have no icon picture. Tried adding ~/.local/share/icons,/usr/share/icons,pixmaps,mime etc. Build doesn't give anything more than this. Also I don't use flatpak or snap but where are their desktop files stored? We may need to whitelist those too,

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flatpak: /var/lib/flatpak/exports/share/{applications,icons} and ~/.local/share/flatpak/exports/share/{applications,icons}

some of the entries have no icon picture.

Are these icons specified by name or by path?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you locate for the name?

Copy link
Contributor Author

@bbhtt bbhtt Jul 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found them. Most of them are in, /var/lib/app-info/icons/. Does this vary by distro?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fedora seems to use /usr/share/app-info/.

Copy link
Contributor Author

@bbhtt bbhtt Jul 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arch uses /usr/share/icons/ in hicolor.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW:

  • Snap: don't use bubblewrap
  • flatpak: relies on bubblewrap
  • nautilus: runs thumbnailers in a sandbox with a read-only filesystem

etc/profile-a-l/kazam.profile Outdated Show resolved Hide resolved
etc/profile-a-l/kazam.profile Outdated Show resolved Hide resolved
etc/profile-m-z/onboard.profile Outdated Show resolved Hide resolved
Removed blacklist,no3d; added icon flatpak paths;sorting;added space
@rusty-snake
Copy link
Collaborator

I lost the overview, anything left?

@bbhtt
Copy link
Contributor Author

bbhtt commented Aug 30, 2020

<...>

I lost the overview, anything left?

I forgot, I thought you kept one unresolved for the icon dirs.

According to snap docs desktop files are copied to usual dirs: https://snapcraft.io/docs/desktop-menu-icon-support, so I think it's good to go. I've removed the unrelated comments...

@rusty-snake rusty-snake merged commit a5e2b31 into netblue30:master Sep 2, 2020
@rusty-snake
Copy link
Collaborator

Thanks for this contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants