Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profile for otter-browser #3564

Merged
merged 2 commits into from
Aug 4, 2020
Merged

Add profile for otter-browser #3564

merged 2 commits into from
Aug 4, 2020

Conversation

bbhtt
Copy link
Contributor

@bbhtt bbhtt commented Aug 1, 2020

Request: # 1139

Copy link
Collaborator

@Fred-Barclay Fred-Barclay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Just had a few comments...

noblacklist ${HOME}/.local/share/pki
noblacklist ${HOME}/.cache/Otter
noblacklist ${HOME}/.config/otter

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alphabetise

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

whitelist ${HOME}/.pki
whitelist ${HOME}/.cache/Otter
whitelist ${HOME}/.config/otter
whitelist ${HOME}/.local/share/pki
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also alphabetise

shell none

disable-mnt
private-cache
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is a private-bin possible?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private-bin will break right-clicking Downloads and opening files among other things. Opera,Falkon,Firefox Chromium-common, all have none or commented. Do you want me to add the basic stuff like otter,sh,bash,which?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will break right-clicking Downloads and opening files

I don't think we support this for other browsers

Opera,Falkon,Firefox Chromium-common

The reason is that the most distros ship custom/own shell-scripts to start firefox.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add the above private-bin.

include disable-exec.inc
include disable-interpreters.inc
include disable-passwdmgr.inc
include disable-programs.inc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include disable-xdg.inc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sort.py keeps copying each line twice!

@rusty-snake rusty-snake merged commit 4aa6226 into netblue30:master Aug 4, 2020
@rusty-snake
Copy link
Collaborator

Merged, Thanks.

@bbhtt bbhtt deleted the otter branch August 12, 2020 07:32
@matu3ba matu3ba mentioned this pull request Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants