-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add profile for otter-browser #3564
Conversation
Initial
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good! Just had a few comments...
noblacklist ${HOME}/.local/share/pki | ||
noblacklist ${HOME}/.cache/Otter | ||
noblacklist ${HOME}/.config/otter | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alphabetise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
whitelist ${HOME}/.pki | ||
whitelist ${HOME}/.cache/Otter | ||
whitelist ${HOME}/.config/otter | ||
whitelist ${HOME}/.local/share/pki |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also alphabetise
shell none | ||
|
||
disable-mnt | ||
private-cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is a private-bin possible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private-bin
will break right-clicking Downloads and opening files among other things. Opera,Falkon,Firefox Chromium-common, all have none or commented. Do you want me to add the basic stuff like otter,sh,bash,which
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will break right-clicking Downloads and opening files
I don't think we support this for other browsers
Opera,Falkon,Firefox Chromium-common
The reason is that the most distros ship custom/own shell-scripts to start firefox.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add the above private-bin
.
include disable-exec.inc | ||
include disable-interpreters.inc | ||
include disable-passwdmgr.inc | ||
include disable-programs.inc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include disable-xdg.inc
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sort.py
keeps copying each line twice!
Merged, Thanks. |
Request: # 1139