Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --include #3571

Merged
merged 2 commits into from
Sep 11, 2020
Merged

add --include #3571

merged 2 commits into from
Sep 11, 2020

Conversation

rusty-snake
Copy link
Collaborator

closes #2923

@smitsohu
Copy link
Collaborator

smitsohu commented Aug 17, 2020

Looks good to me. I still wonder if --include and --profile in the end should do the profile search the same way, including handling of file extensions.

Then the only difference would be that --profile overrides automatic profile loading, whereas --include just loads additional instructions from a file.

while (*ptr != '/' && *ptr != '\0')
ptr++;
if (*ptr == '\0') {
// ppath contains no '/', assume it's a name
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to somehow prioritize search in the current working directory?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Looks good to me. I still wonder if --include and --profile in the end should do the profile search the same way, including handling of file extensions.

Then the only difference would be that --profile overrides automatic profile loading, whereas --include just loads additional instructions from a file.

I tried first, but I don't completely understand the --profile code. What does has_colon.

@netblue30
Copy link
Owner

@rusty-snake - looks fine, are you merging it?

@rusty-snake rusty-snake marked this pull request as ready for review September 11, 2020 10:06
@rusty-snake rusty-snake merged commit 449df86 into netblue30:master Sep 11, 2020
@rusty-snake rusty-snake deleted the include-on-cli branch September 11, 2020 10:07
@matu3ba matu3ba mentioned this pull request Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

include on the commandline
3 participants