Add profile for straw-viewer #3742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusty-snake
approved these changes
Nov 12, 2020
There was a problem hiding this comment.
LGTM
Are the video-players listed in private-bin (e.g. mpv, vlc, ...) started by straw-viewer or gtk-straw-viewer? If they are started by straw-viewer the blacklist /tmp/.X11-unix will break.
What about adding noblacklist and whitelist for the config files of mpv,smplayer,vlc,youtube-dl?
glitsj16
reviewed
Nov 12, 2020
| # Persistent local customizations | ||
| include gtk-straw-viewer.local | ||
| # Persistent global definitions | ||
| # include globals.local |
There was a problem hiding this comment.
Please use our format for explaining why globals.local is not included here:
# added by included profile
#include globals.local
|
Those are the three players it currently supports by default but you can add any player in the config file. It passes some parameters to ignore existing configs so I don't think adding the player's config paths are necessary.
I'll make rest of the changes.
Edit. Somehow I messed up the filenames.
…On November 12, 2020 4:41:38 PM UTC, rusty-snake ***@***.***> wrote:
@rusty-snake approved this pull request.
LGTM
Are the video-players listed in `private-bin` (e.g. mpv, vlc, ...)
started by straw-viewer or gtk-straw-viewer? If they are started by
straw-viewer the `blacklist /tmp/.X11-unix` will break.
What about adding `noblacklist` and `whitelist` for the config files of
mpv,smplayer,vlc,youtube-dl?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#3742 (review)
|
|
merged, thanks. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.