Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build.yml #3779

Merged
merged 8 commits into from
Nov 29, 2020
Merged

Update build.yml #3779

merged 8 commits into from
Nov 29, 2020

Conversation

rusty-snake
Copy link
Collaborator

Currently we run all actions for all commits. This is not resource friendly. Let's tweak this a bit.

This commit adds support for "skip ci" tags (i.e. if the head commit contains [skip ci], no jobs are executed.
In addition are all commits which modify non-code files (e.g. README) only excluded.

Furthermore we should not run cppcheck and scan-build if only profiles are changed and sort.py need only to be execute if profiles are changed.

Currently we run all actions for all commits. This is not resource friendly. Let's tweak this a bit.

This commit adds support for "skip ci" tags (i.e. if the head commit contains [s k i p   c i] (w/o the extra spaces used to escape here), no jobs are executed.
In addition are all commits which modify non-code files (e.g. README) only excluded.

Furthermore we should not run cppcheck and scan-build if only profiles are changed and sort.py need only to be execute if profiles are changed.
Copy link
Collaborator

@Fred-Barclay Fred-Barclay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

@glitsj16
Copy link
Collaborator

Very nice indeed. I had noticed things tend to take a long while for a simple profile change to get the green light.

profile-sort is now in sort.yml
fix syntax
    paths-ignore:
      - CONTRIBUTING.md
      - README
      - README.md  
      - RELNOTES
      - SECURITY.md
      - 'etc/**'
@rusty-snake rusty-snake marked this pull request as ready for review November 29, 2020 07:44
@reinerh
Copy link
Collaborator

reinerh commented Nov 29, 2020

Nice changes! I like it.

Does github.event.commits[0].message check the whole message or only the summary line (I noticed in some earlier commits you added it to the summary)?
(IMHO having this kind of metadata in the commit body looks nicer when reading the log)

@rusty-snake
Copy link
Collaborator Author

Does github.event.commits[0].message check the whole message or only the summary line

AFAICTY it's the whole message (the docs aren't really helpfull).

IMHO having this kind of metadata in the commit body looks nicer when reading the log

agree

@rusty-snake rusty-snake merged commit 4b0b7ec into master Nov 29, 2020
@rusty-snake rusty-snake deleted the rusty-snake-patch-1-action-tweaks branch November 29, 2020 14:04
FastAlien pushed a commit to FastAlien/firejail that referenced this pull request Dec 3, 2020
* Update build.yml

Currently we run all actions for all commits. This is not resource friendly. Let's tweak this a bit.

This commit adds support for "skip ci" tags (i.e. if the head commit contains [s k i p   c i] (w/o the extra spaces used to escape here), no jobs are executed.
In addition are all commits which modify non-code files (e.g. README) only excluded.

Furthermore we should not run cppcheck and scan-build if only profiles are changed and sort.py need only to be execute if profiles are changed.

* Create sort.yml

* Update build.yml

profile-sort is now in sort.yml

* Update sort.yml

fix syntax

* Update codeql-analysis.yml

    paths-ignore:
      - CONTRIBUTING.md
      - README
      - README.md  
      - RELNOTES
      - SECURITY.md
      - 'etc/**'

* Create build-extra.yml

* Update build.yml

* Update build-extra.yml
@matu3ba matu3ba mentioned this pull request Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants