Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename whitelist-players.inc to whitelist-player-common.inc #3819

Merged
merged 8 commits into from
Dec 15, 2020
Merged

rename whitelist-players.inc to whitelist-player-common.inc #3819

merged 8 commits into from
Dec 15, 2020

Conversation

glitsj16
Copy link
Collaborator

whitelist-player-common.inc fits in with the naming-scheme used throughout our codebase

IMPORTANT NOTE:
users will have to rename their whitelist-players.local to whitelist-player-common.local to ensure stuff stays working as expected

@rusty-snake
Copy link
Collaborator

OT: We could also rename softmaker-common.inc to softmaker-common.profile. We use *-common.profile for commons based on same code-base and *-common.inc for commons based on same usage target (e.g. wusc or players).

@glitsj16
Copy link
Collaborator Author

OT: We could also rename softmaker-common.inc to softmaker-common.profile. We use *-common.profile for commons based on same code-base and *-common.inc for commons based on same usage target (e.g. wusc or players).

@rusty-snake That's a great idea, thanks for pointing it out. Adding it to the to-do list, unless you beat me to it :-)

@glitsj16 glitsj16 marked this pull request as ready for review December 15, 2020 13:06
@glitsj16 glitsj16 merged commit d529447 into netblue30:master Dec 15, 2020
@glitsj16 glitsj16 deleted the refactor-wpc branch December 15, 2020 16:23
glitsj16 added a commit that referenced this pull request Dec 15, 2020
* Rename etc/inc/softmaker-common.inc to etc/profile-m-z/softmaker-common.profile

As per suggestion by @rusty-snake in #3819 (comment)

* softmaker-common.profile name change

* softmaker-common.profile name change

* softmaker-common.profile name change

* softmaker-common.profile name change

* softmaker-common.profile name change

* softmaker-common.profile name change

* softmaker-common.profile name change

* softmaker-common.profile name change

* softmaker-common.profile name change
@matu3ba matu3ba mentioned this pull request Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants