-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor archivers #3820
Refactor archivers #3820
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
etc/inc/archiver-common.inc
Outdated
|
||
# common profile for archiver/compression tools | ||
|
||
blacklist ${RUNUSER}/wayland-* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can blacklist ${RUNUSER}
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rusty-snake Thanks for having a look at this draft. I'm in the middle of testing all my archivers including their .local overrides. Will add blacklist ${RUNUSER}
to the tests but indeed, I agree this shouldn't pose any problems. The plan is to bring existing profiles in an easier-to-change state using archive-common.inc as baseline and do specific changes in seperate PR's once this is merged. Shouldn't take all that long to get the first part finished.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rusty-snake I added blacklist ${RUNUSER}
to archiver-common.inc. What's the point in having that in combination with blacklist ${RUNUSER}/wayland-*
again? I see such a doubling in several other profiles (curl, dig, drill, file, wget to name a few) but I can't say I actually understand the why. If ${RUNUSER} is blacklisted, shouldn't that imply ${RUNUSER}/wayland-* (and any other subdir for that matter) is blacklisted too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blacklist ${RUNUSER}/wayland-*
is useless with blacklist ${RUNUSER}
and can be simplified, that's right.
The profiles are written with this logic:
If not requires(X11) then
If 'net none' then
add 'x11 none'
Else
add 'blacklist /tmp/.X11-unix'
Fi
Fi
If 'x11 none' or 'blacklist /tmp/.X11-unix' then
add 'blacklist ${RUNUSER}/wayland-*'
Fi
If possible_to_add(wruc) then
add wruc
Fi
If get_used_commands(wruc) == nil then
replace wruc with 'blacklist ${RUNUSER}'
Fi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rusty-snake Thanks for the explanation! I'll do the needed changes in a minute, before I forget. It sure is a luxury to have you on board :-)
Thanks to @rusty-snake for suggesting this.
…n.inc See discussion in #3820 (comment)
Introduce
archive-common.inc
: common file for all archivers.For now this WIP simply recreates existing archiver profiles.
It's intention is to:
E.g. most have nogroups and have noroot commented, but a few divert from this pattern. I intend to do a follow-up review after extended testing, so for now this is a WIP.