-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New profile for CoyIM #3853
New profile for CoyIM #3853
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly good aside from minor things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tried to make it as restrictive as I could and follow the guidelines of the template. It is however the first firejail profile I create, so any input or feedback would be very welcome.
It's always better to make more review steps and have a profile 😄 . So here're my inputs.
- Can we use
include whitelist-runuser-common.inc
,include whitelist-usr-share-common.inc
,include whitelist-var-common.inc
? - Add
blacklist ${HOME}/.config/coyim
todisable-programs.inc
- Add
coyim
tosrc/firecfg/firecfg.config
.
I have added the suggested changes. |
Thank you for your feedback.
What's the rulebook regarding the inclusion of whitelist-*? Isn't it preferable to avoid adding additional inclusions if they are not necessary to the proper functioning of the application? |
edit: wusc maybe need something like |
Had you found time to test CoyIM with wruc, wusc and wvc. |
Yep, works fine. |
merged, thanks! |
I have created here a first profile for CoyIM. I have tried to make it as restrictive as I could and follow the guidelines of the template. It is however the first firejail profile I create, so any input or feedback would be very welcome.