profiles: signal-desktop: remove invalid ignore include-xdg.inc #4001
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusty-snake
reviewed
Feb 21, 2021
Added on commit f4f6767 ("Refactor electron.profile and electron based programs (netblue30#3807)"). This appears to be the only instance of that: $ grep -Fnr 'include-xdg' etc etc/profile-m-z/signal-desktop.profile:9:ignore include-xdg.inc Simply fixing the typo would enable xdg dirs for the first time since the aforementioned commit. But, as talked with @rusty-snake[1], since there has been no negative feedback, and since it's a whitelisting profile, just remove the affected line instead. Credits go to syntax highlighting on vim. [1]: netblue30#4001
kmk3
force-pushed
the
fix-signal-xdg-ignore
branch
from
c294af3
to
9616146
Compare
kmk3
changed the title
Alright; removed the ignore and force-pushed. |
rusty-snake
approved these changes
Feb 22, 2021
|
all set, thanks |
kmk3
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added on commit f4f6767 ("Refactor electron.profile and electron based
programs (#3807)").
This appears to be the only instance of that:
Credits go to syntax highlighting on vim.
Also, note that the file says this:
So if there was no negative feedback, should xdg dirs (other than
${DOWNLOADS}, that is) be allowed or should we just remove that line instead?As all this PR would do is allow xdg dirs for the first time since at least
commit f4f6767.