add PATH_FCOPY to private-lib automatically #4004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitsohu
force-pushed
the
privatelib4
branch
3 times, most recently
from
3a1402d
to
5d62b15
Compare
restore 4530462, but now run fldd as root user. This became necessary because in the meantime read permission on helper executables was removed. Puts infrastructure in place to add other helper binaries to private-lib as well, should the need arise.
smitsohu
force-pushed
the
privatelib4
branch
from
5d62b15
to
a274ad1
Compare
|
all set, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially restores 4530462. Removing read permission on helper executables (fcopy) broke this original fix.
Now run fldd as root in order to fix #3741 without having to compromise or give up on the new permission system. It runs as root only on binaries that are not controlled by the user, and that Firejail needs to trust anyway. Also infrastructure is put in place to add more helper binaries to private-lib, should the need arise.
This pull request might be useful also for other reasons. For example, if one day we want to run the test suite with ASan/UBsan instrumentation, private-lib should now pick up all necessary libraries automatically (again).