Improve error messages #4035
Merged
Improve error messages #4035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move error message after debug logging and add cause message. Signed-off-by: Tomi Leppänen <tomi.leppanen@jolla.com>
Better for portability and consistency. Currently strerror() is used everywhere else, so use it here as well. printf's %m is a glibc extension that is supported also by some other libc implementations. Signed-off-by: Tomi Leppänen <tomi.leppanen@jolla.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I sent some changes recently (#3998) and now I noticed that there were some minor things that could have been better.
The first commit moves error message of missing directory while mounting after debug logging so that it's easy to see when the error happens and adds a cause message. The second commit changes %m usages introduced by the changes I made. While %m is reentrant and allows very nice and clean code, it's not consistent with the rest of firejail and also not portable across libc implementations.