reorganizing youtube-viewers

[pirate486743186]

reorganizing youtube-viewer and straw-viewer with youtube-viwers-common
adding pipe-viewer

[rusty-snake]

• gtk-pipe-viewer and pipe-viewer need to be added to firecfg.config.
• The private-bin lines need more work:
  • /usr/bin/firefox is only wrapper script on the most system. Every distro has its own. The current private-bin does not work for firefox on the most system.
  • why do we have no chromium, whatever?
  • Having a private-bin with e.g. vlc give the impression it is supported to start it though I don't think this works because of the whitelist and disable-program.inc.
• quiet does not work this way (see below).

---

Something like this should be first done on a branch on your fork. Then you can create a PR with it.
A Draft/WIP PR is good for bigger changed to get earlier review but not to active develop (= commit every few minutes) on it.

[pirate486743186]

* [ ]  gtk-pipe-viewer and pipe-viewer need to be added to firecfg.config.

I think you where the one complaining that it creates merge conflicts?

* [ ]  The `private-bin` lines need more work:
  
  * [ ]  /usr/bin/firefox is only wrapper script on the most system. Every distro has its own. The current private-bin does not work for firefox on the most system.
  * [ ]  why do we have no chromium, whatever?
  * [ ]  Having a private-bin with e.g. vlc give the impression it is supported to start it though I don't think this works because of the `whitelist` and disable-program.inc.

profiles for youtube-viewer, straw-viewer and their gtk front ends already existed. I copy pasted what they had.

[pirate486743186]

lol... yea, vlc is broken (it wasn't me)

they use a video player and a terminal like addons.
they can also launch a webpage in a browser.
The exact application doesn't matter.

so firefox, mpv, xterm are just the usual defaults that will work for most users.

[rusty-snake]

gtk-pipe-viewer and pipe-viewer need to be added to firecfg.config.

I think you where the one complaining that it creates merge conflicts?

I said "(for the future) Please don't add new profiles to README.md/RELNOTES in PRs, it just create merge conflicts" (#4023 (comment)). README.md and RELNOTES have everything on a few line and are added by appending. firecfg.config has it over hundreds lines which are ordered alphabetically (more or less). README.md/RELONTES will conflict if two PR with a new profile are create while firecfg only if they have a name with the same prefix (e.g. youtube-viewer and youtube-watcher).

profiles for youtube-viewer, straw-viewer and their gtk front ends already existed. I copy pasted what they had.

I know I just saw that this doesn't make any sense and we should correct this.

so firefox, mpv, xterm are just the usual defaults that will work for most users.

Firefox needs to be tested on Arch, Fedora, Debain and maybe more.

[pirate486743186]

the external applications that are launched are configurable. You can literally use any terminal, video player and web browser.

firefox, mpv and xterm are nice defaults.

the video player is very important. The terminal is for a lesser feature, and the web browser is of little importance.

i think it's better to remove vlc. And we shouldn't stress about firefox or chromium.

[pirate486743186]

why you aren't merging it?

[rusty-snake]

• PR is still in Draft state
• wruc-for-all thread is unresolved
• noinput is missing (because of the long time)

[rusty-snake]

merged, thanks!

[pirate486743186]

you forgot to mention pipe-viewer and gtk-pipe-viewer in the relnotes....

[rusty-snake]

I haven't forgotten them, I just don't always add them immediately.