Encourage making overrides in *.local files #4165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Didn't read all rewrite but looks great. If this catched all |
@rusty-snake |
glitsj16
added a commit
that referenced
this pull request
May 13, 2021
* Follow-up for #4165 * Follow-up for #4165 * Follow-up for #4165 * Follow-up for #4165 * Follow-up for #4165 * Follow-up for #4165 * Follow-up for #4165 * Follow-up for #4165 * Follow-up for #4165 * Follow-up for #4165 * Follow-up for #4165 * Follow-up for #4165 * Follow-up for #4165 * fix noroot comment As suggested [here](#4271 (comment)). * fix dbus-user comment As suggested [here](#4271 (comment)). * fix private-dev comment As suggested [here](#4271 (comment)). * fix private-etc comment As suggested [here](#4271 (comment)). * move writable-var comment cfr. profile.template
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should try to inform users that the best place for persistent local customizations is in .local files. This PR refactors/streamlines comments to make that a bit more obvious.