Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor] gunzip profile broken #4317

Merged
merged 2 commits into from
May 29, 2021
Merged

[minor] gunzip profile broken #4317

merged 2 commits into from
May 29, 2021

Conversation

pirate486743186
Copy link
Contributor

gunzip is a wrapper script of gzip
so it needs "ignore include disable-shell.inc"

glitsj16
glitsj16 reviewed May 28, 2021
View reviewed changes
Copy link
Collaborator

@glitsj16 glitsj16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although ignoring inclusion of disable-shell.inc works, allow-bin-sh.inc exists specifically for situations like this IMO.

@glitsj16 glitsj16 merged commit 0d2cabe into netblue30:master May 29, 2021
@matu3ba matu3ba mentioned this pull request Oct 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glitsj16 glitsj16 glitsj16 left review comments

@reinerh reinerh reinerh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pirate486743186 @glitsj16 @reinerh