Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorganizing links browsers #4320

Merged
merged 24 commits into from
May 31, 2021
Merged

reorganizing links browsers #4320

merged 24 commits into from
May 31, 2021

Conversation

pirate486743186
Copy link
Contributor

@pirate486743186 pirate486743186 commented May 31, 2021

they are a bunch of variants of links

created links-common.profile
adapted links, elinks
fixed xlinks
added links2, xlinks2

EDITED

Copy link
Collaborator

@rusty-snake rusty-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xlinks looks problematic, rest is LGTM.

etc/profile-a-l/links-common.profile Show resolved Hide resolved
etc/profile-a-l/links-common.profile Show resolved Hide resolved
etc/profile-m-z/xlinks.profile Outdated Show resolved Hide resolved
etc/profile-m-z/xlinks.profile Outdated Show resolved Hide resolved
etc/profile-m-z/xlinks.profile Outdated Show resolved Hide resolved
Copy link
Collaborator

@glitsj16 glitsj16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

etc/profile-m-z/xlinks2 Outdated Show resolved Hide resolved
etc/profile-m-z/xlinks2 Outdated Show resolved Hide resolved
pirate486743186 added 2 commits May 31, 2021 17:44
rusty-snake
rusty-snake previously approved these changes May 31, 2021
@rusty-snake
Copy link
Collaborator

doesn't use /tmp/.X11-unix

Can you prove that this is always the case?

@rusty-snake rusty-snake dismissed their stale review May 31, 2021 17:07

unresolved/new question

@pirate486743186
Copy link
Contributor Author

originally xlinks.profile had this too "noblacklist ${HOME}/.links"
it wasn't exactly a high quality profile

wikipedia works fine
you can tell the program is using the bare minimum, in order to have its own window

@rusty-snake
Copy link
Collaborator

originally xlinks.profile had this too "noblacklist ${HOME}/.links"
it wasn't exactly a high quality profile

Having a redundant line does not make every line wrong.

wikipedia works fine

On your system because it uses a TCP-Socket/Abstract-Unix-Socket (try with --net=none/--net=eth0). /tmp/.X11-unix is the location of the X11 (non-abstract) unix-socket (https://unix.stackexchange.com/questions/196677/what-is-tmp-x11-unix).

Can you prove that this is always the case? Either by providing the relevant parts of the source-code or by testing on various systems/configures/….

@rusty-snake
Copy link
Collaborator

rusty-snake commented May 31, 2021

$ screenfetch 
           /:-------------:\          ***@fedora
        :-------------------::        OS: Fedora 
      :-----------/shhOHbmp---:\      Kernel: x86_64 Linux 5.12.5-300.fc34.x86_64
    /-----------omMMMNNNMMD  ---:     Uptime: 6d 11h 33m
   :-----------sMMMMNMNMP.    ---:    Packages: ***
  :-----------:MMMdP-------    ---\   Shell: ***
 ,------------:MMMd--------    ---:   Resolution: 1920x1080
 :------------:MMMd-------    .---:   DE: GNOME 40.0
 :----    oNMMMMMMMMMNho     .----:   WM: Mutter <<=== Wayland
 :--     .+shhhMMMmhhy++   .------/   WM Theme: ***
 :-    -------:MMMd--------------:    GTK Theme: ***
 :-   --------/MMMd-------------;     Icon Theme: ***
 :-    ------/hMMMy------------:      Font: ***
 :-- :dMNdhhdNMMNo------------;       Disk: ***
 :---:sdNMMMMNds:------------:        CPU: Intel Core i5-1035G1 @ 4x 3.6GHz [71.0°C]
 :------:://:-------------::          GPU: Mesa Intel(R) UHD Graphics (ICL GT1)
 :---------------------://            RAM: 4947MiB / 7719MiB

$ firejail --version
firejail version 0.9.65

Compile time support:
	- Always force nonewprivs support is enabled
	- AppArmor support is disabled
	- AppImage support is enabled
	- chroot support is disabled
	- D-BUS proxy support is enabled
	- file and directory whitelisting support is enabled
	- file transfer support is disabled
	- firetunnel support is disabled
	- networking support is enabled
	- output logging is disabled
	- overlayfs support is disabled
	- private-home support is disabled
	- private-cache and tmpfs as user enabled
	- SELinux support is enabled
	- user namespace support is enabled
	- X11 sandboxing support is disabled

$ links -version
Links 2.20.2
$ firejail --private links -g https://wikipedia.org/
# Works
$ firejail --private --blacklist=/tmp/.X11-unix links -g https://wikipedia.org/
# Works
$ firejail --private --blacklist=/tmp/.X11-unix --net=wlp... links -g https://wikipedia.org/
Could not initialize any graphics driver. Tried the following drivers:
x:
Can't open display ":0"
fb:
Could not get VT mode.

EDIT:

firejail --private --net=wlp2s0 links -g https://wikipedia.org/ does not work either. But we blacklist /tmp/.X11-unix for some reasons and the "old" profile has it. Need to check more.

EDIT2:

Test with mpv:

$ firejail --noprofile --blacklist='${RUNUSER}/wayland-*' mpv …
# Works
$ firejail --noprofile --blacklist='${RUNUSER}/wayland-*' --net=none mpv …
# Works
$ firejail --noprofile --blacklist='${RUNUSER}/wayland-*' --blacklist=/tmp/.X11-unix mpv …
# Works
$ firejail --noprofile --blacklist='${RUNUSER}/wayland-*' --blacklist=/tmp/.X11-unix --net=none mpv …
# No window

Summary: Many factors that influence/condition each other.

Copy link
Collaborator

@rusty-snake rusty-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Deleted] (GH does not allow you to delete reviews)

Copy link
Collaborator

@rusty-snake rusty-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

@rusty-snake rusty-snake merged commit c3c52ef into netblue30:master May 31, 2021
@rusty-snake
Copy link
Collaborator

Merged, thanks.

@pirate486743186 pirate486743186 deleted the patch-1 branch June 4, 2021 09:38
@matu3ba matu3ba mentioned this pull request Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants