-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: fix file mode of shell scripts (644 -> 755) #5206
Conversation
Some shell scripts are not executable, so fix their file modes: $ git grep -Elz '^#!/bin/(ba)?sh' | xargs -0 -I '{}' \ chmod +x '{}' Files changed: * src/fgit/fgit-uninstall.sh * src/tools/extract_errnos.sh Note: I have manually checked that the files above are indeed intended to be executable directly and not just sourced, as a script of the latter kind could also contain a shebang (for example, to help ensure proper syntax highlighting). Misc: The affected files were added on commit e46dd3e ("git-install", 2017-02-04) and on commit 081d1fb ("Add seccomp errno filter support", 2015-09-23) / PR netblue30#66, respectively.
LGTM, note that extract_errnos.sh is mostly a dev-time thing and not that useful for a end user i guess |
I have to do some cleanup there, we disconnected src/fgit from the interface a long time ago, The files in src/tools are for development only. |
@netblue30 commented on Jun 17:
I don't understand why you mention this. The file mode changes were made because regardless of the target audience, the Misc: I mostly created a PR (instead of committing directly) as a reminder to |
@netblue30 commented on Jun 17:
For reference: commit 756fed6 ("remving src/fgit", 2022-06-17). I was going to commit a removal of the leftover build: remove remnants of --git-install / --git-uninstall This amends commit 23d10c8 ("deprecated --git-install and Relevant options and variables:
With this commit, it looks like all traces of the above are fully removed:
|
The following leverages the fact that when using a normal merge (as opposed to "rebase and merge" or "squash and merge") on GitHub, the pull request number is put in the commit message title and the title of the PR is added to the commit message body. Commands used to find and print the items for the RELNOTES: $ git log --grep='^build:' --merges --reverse --pretty='%s %b' 0.9.70.. | sed -E -n 's/Merge pull request (#[0-9]+) from [^ ]+ (.*)/ * \2 (\1)/p' * build: deduplicate configure-time vars into new config files (netblue30#5140) * build: fix file mode of shell scripts (644 -> 755) (netblue30#5206) * build: reduce autoconf input files from 32 to 2 (netblue30#5219) Commands used to generate the message below: $ git log --grep='^build:' --merges --reverse --pretty='%s %b' 0.9.70.. | sed -E -n 's/Merge pull request (#[0-9]+).*/\1/p' | sort | tr '\n' ' ' | sed -E 's/^(.*) /Relates to \1./' Relates to netblue30#5140 netblue30#5206 netblue30#5219. Relates to netblue30#5140 netblue30#5206 netblue30#5219.
The following leverages the fact that when using a normal merge (as opposed to "rebase and merge" or "squash and merge") on GitHub, the pull request number is put in the commit message title and the title of the PR is added to the commit message body. Commands used to find and print the items for the RELNOTES: $ git log --grep='^build:' --merges --reverse --pretty='%s %b' 0.9.70.. | sed -E -n 's/Merge pull request (#[0-9]+) from [^ ]+ (.*)/ * \2 (\1)/p' * build: deduplicate configure-time vars into new config files (#5140) * build: fix file mode of shell scripts (644 -> 755) (#5206) * build: reduce autoconf input files from 32 to 2 (#5219) Commands used to generate the message below: $ git log --grep='^build:' --merges --reverse --pretty='%s %b' 0.9.70.. | sed -E -n 's/Merge pull request (#[0-9]+).*/\1/p' | sort | tr '\n' ' ' | sed -E 's/^(.*) /Relates to \1./' Relates to #5140 #5206 #5219. Relates to #5140 #5206 #5219.
Some shell scripts are not executable, so fix their file modes:
Files changed:
Note: I have manually checked that the files above are indeed intended
to be executable directly and not just sourced, as a script of the
latter kind could also contain a shebang (for example, to help ensure
proper syntax highlighting).
Misc: The affected files were added on commit e46dd3e ("git-install",
2017-02-04) and on commit 081d1fb ("Add seccomp errno filter support",
2015-09-23) / PR #66, respectively.
Cc: @netblue30 @wader