build: add dist build directory to .gitignore #5248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore it only on the repository root path, as a directory that matches `firejail-*` could eventually be added. Note that the dist archive is already ignored since commit da6b131 ("chore(.gitignore) ignore built packages", 2018-01-15) / PR netblue30#1733. Example paths: * build dir: firejail-0.9.71/ * archive: firejail-0.9.71.tar.xz See `$(NAME)-$(VERSION)` and `$(NAME)-$(VERSION).tar.xz` in the "dist" target on the root Makefile.
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Jul 12, 2022
Add the following paths to the ignore lists:
- .git-blame-ignore-revs
- .gitignore
- COPYING
To avoid running CI unnecessarily.
Commands used to show only the root files:
$ git ls-files | grep -v /
Misc: Noticed the missing paths on netblue30#5248.
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Jul 12, 2022
Add the following paths to the ignore lists:
- .git-blame-ignore-revs
- .gitignore
- COPYING
To avoid running CI unnecessarily.
Commands used to show only the root files:
$ git ls-files | grep -v /
Misc: I noticed the missing paths on netblue30#5248.
rusty-snake
approved these changes
Jul 13, 2022
reinerh
approved these changes
Jul 13, 2022
ChrysoliteAzalea
pushed a commit
to ChrysoliteAzalea/firejail
that referenced
this pull request
Aug 2, 2022
Add the following paths to the ignore lists:
- .git-blame-ignore-revs
- .gitignore
- COPYING
To avoid running CI unnecessarily.
Commands used to show only the root files:
$ git ls-files | grep -v /
Misc: I noticed the missing paths on netblue30#5248.
ChrysoliteAzalea
pushed a commit
to ChrysoliteAzalea/firejail
that referenced
this pull request
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore it only on the repository root path, as a directory that matches
firejail-*could eventually be added.Note that the dist archive is already ignored since commit da6b131
("chore(.gitignore) ignore built packages", 2018-01-15) / PR #1733.
Example paths:
See
$(NAME)-$(VERSION)and$(NAME)-$(VERSION).tar.xzin the "dist"target on the root Makefile.