Fix an AppArmor profile denial issue with ptrace reading and signals #5317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glitsj16
approved these changes
Aug 15, 2022
kmk3
added a commit
that referenced
this pull request
Aug 18, 2022
This was referenced Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone!
Recently, a pull request was merged that added support for custom AppArmor profiles. However, there was a use-case I haven't tested -- a case where an application confined by a default profile uses ptrace or sends signals. In the original profile, it was allowed only for apps with the same security label. However, I've missed that, while firejail-default//&unconfined and firejail-default have equal AppArmor permissions, ptrace reading and sending signals were previously allowed for peers only with the latter security label. I've fixed it in this PR by allowing both.
Fixes #5316