Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StepSecurity] ci: Harden GitHub Actions #5439

Conversation

step-security-bot
Copy link
Contributor

Summary

This is an automated pull request generated by Secure Workflows at the request of @topimiettinen. Please merge the Pull Request to incorporate the requested changes. Please tag @topimiettinen on your message if you have any questions related to the PR. You can also engage with the StepSecurity team by tagging @step-security-bot.

Security Fixes

Least Privileged GitHub Actions Token Permissions

The least privilged token permissions were calculate using Secure WorkFlows based on the actions included in the GitHub Workflow files. This is recommended by GitHub as well as The Open Source Security Foundation (OpenSSF).

Pinned Dependencies

A pinned dependency is a dependency that is explicitly set to a specific hashed version instead of a mutable version. Pinned dependencis ensure that development and deployment are done with the same software versions which reduces deployment risks, and enables reproducibility. It can help mitigate compromised dependencies from undermining the security of the project in certain scenarios. The dependencies were pinned using Secure WorkFlows

Harden Runner

This PR adds Harden-Runner in GitHub actions workflows to improve security. It is an open-source purpose-built security monitoring agent for GitHub hosted runners. It monitors the runtime behavior of the build environment to provide security insights. Optionally, it can also lock down the build environment.

Feedback

For bug reports, feature requests, and general feedback; please create an issue in step-security/secure-workflows or contact us via our website.

Signed-off-by: StepSecurity Bot bot@stepsecurity.io

Signed-off-by: StepSecurity Bot <bot@stepsecurity.io>
Copy link
Collaborator

@rusty-snake rusty-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@topimiettinen topimiettinen merged commit d8a5f38 into netblue30:master Oct 31, 2022
kmk3 added a commit that referenced this pull request Nov 28, 2022
kmk3 added a commit that referenced this pull request May 3, 2023
Relevant lines from build_and_test[1]:

    endpoint called ip address:port 1.1.1.1:1025, domain:
    endpoint called ip address:port 54.185.253.63:43, domain: whois.pir.org.
    ##[error]StepSecurity Harden Runner: DNS resolution for domain dns.quad9.net. was blocked. This domain is not in the list of allowed-endpoints.
    ##[error]StepSecurity Harden Runner: DNS resolution for domain whois.pir.org. was blocked. This domain is not in the list of allowed-endpoints.

The relevant tests were added in the following commits:

* ef4409e ("added whois and dig profiles", 2018-08-30)
* 1718982 ("more profile fixes/testing", 2023-01-19)

Relates to #5439 #5485.

[1] https://github.com/netblue30/firejail/actions/runs/4854586882/jobs/8652141329
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done (on RELNOTES)
Development

Successfully merging this pull request may close these issues.

3 participants