ci: sort and ignore more paths #5481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leave quotes only on paths with wildcards so that they are sorted before normal paths, then sort everything. Note that in the current workflow files, ignored directories always use wildcards, so this also ensures that ignored directories (along with all other paths with wildcards) are always listed before ignored files (similarly to `--group-directories-first` in GNU `ls`). This order is similar to the one on .github/workflows/profile-checks.yml.
Ensure that the following paths are ignored everywhere: - '.github/ISSUE_TEMPLATE/*' - .github/pull_request_template.md To avoid running CI unnecessarily. Currently, they're only ignored on .github/workflows/build-extra.yml.
Ensure that the following files are ignored everywhere: - .github/dependabot.yml - .gitlab-ci.yml To avoid running CI unnecessarily.
Ensure that the following file is ignored everywhere, except on its own workflow: - .github/workflows/codeql-analysis.yml To avoid running CI unnecessarily. This should also make the CI checks finish faster on most PRs opened by dependabot, as they're often only about bumping the version of codeql-action and are opened about once a week (see .github/dependabot.yml).
Ignore the following file: - src/firecfg/firecfg.config To avoid running CodeQL when only adding a new profile. Note: This is already ignored on .github/workflows/build-extra.yml since commit 23ea15f ("Add some more paths-ignore to build-extra.yml", 2021-04-24). Misc: I noticed this on netblue30#5289.
Ignore the following paths: - 'contrib/vim/**' - 'src/man/*.txt' To avoid running CI unnecessarily. Note: build-extra essentially only builds with clang and runs linters on the C code, so changes to the man pages and vim files should not affect the result. Do not ignore them on .github/workflows/build.yml because they are part of DISTFILES (see the root Makefile). Misc: I noticed this on netblue30#5296 (man pages).
kmk3
force-pushed
the
ci-sort-ignore-paths
branch
from
3e1f885 to
2499a3b
Compare
|
Force-push changes: All directories appear to be using wildcards, so I put them also on the vim Not sure if it's required or not, as they appear to always be used in the docs: But I also noticed the following and added it to the first commit message:
|
|
Cool! |
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Jan 28, 2023
See commit 9bf5e45 ("ci: sort items on paths-ignore lists", 2022-07-12) / PR netblue30#5481.
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Apr 24, 2023
This makes each workflow ignore every other workflow. Relates to netblue30#5481.
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Apr 25, 2023
This makes each workflow ignore every other workflow. Relates to netblue30#5481.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits:
Sort the paths and then ignore unnecessary files (mainly ignore workflow files
in other workflows).
Relates to #5249.
Kind of relates to #5289 #5296.