profiles: fix misc in kmail/transmission-qt & add kontact.profile #5905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KMail needs sound access to play notification sounds when an email is received.
Kontact profile largely based on kmail profile with additions, kontact also uses kmail for email so it is sensible to only add "noblacklist"s since the configuration files are shared.
rusty-snake
reviewed
Jul 17, 2023
|
@rusty-snake All your suggestions are now implemented, thanks again :) |
kmk3
requested changes
Jul 18, 2023
rusty-snake
reviewed
Jul 18, 2023
kmk3
changed the title
kmk3
changed the title
|
Merged as is for now, there might be some fixes coming later. Thanks @Sadoon-AlBader |
kmk3
changed the title
kmk3
added a commit
that referenced
this pull request
Dec 22, 2024
See etc/templates/redirect_alias-profile.template. This amends commit 1e92326 ("Create kontact.profile", 2023-07-17) / PR #5905. Suggested-by: @rusty-snake
kmk3
added a commit
that referenced
this pull request
Dec 22, 2024
Added on commit 1e92326 ("Create kontact.profile", 2023-07-17) / PR #5905. Suggested-by: @rusty-snake
kmk3
added a commit
that referenced
this pull request
Dec 22, 2024
Relates to #5905. Suggested-by: @rusty-snake
kmk3
added a commit
that referenced
this pull request
Dec 22, 2024
This amends commit 4d00897 ("Enable systray support with condition ?ALLOW_TRAY", 2023-07-18) / PR #5905. Suggested-by: @rusty-snake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes "nosound" from kmail.profile to allow notification sounds, and also adds a "dbus-user.talk org.freedesktop.Notifications" to allow notifications to start.
Also adds kontact.profile based on kmail.profile, have been using it and works well.
Also edits transmission-qt.profile to allow systray, commented out as is usually the case with profiles, but better to at least let the user know that it might be necessary to add to .local if they need systray.
EDIT: if the maintainers also prefer to keep "nosound" for kmail, it might make sense to also add it to kontact.profile since I didn't add it there to start, I think it makes sense to either remove it or add a comment letting the user know that sound notifications won't work unless they "ignore nosound"