Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New profile: tidal-hifi #6009

Merged
merged 1 commit into from
Oct 5, 2023
Merged

New profile: tidal-hifi #6009

merged 1 commit into from
Oct 5, 2023

Conversation

jtrv
Copy link

@jtrv jtrv commented Sep 16, 2023

modified src/firecfg/firecfg.config to add tidal-hifi
created etc/profile-m-z/tidal-hifi.profile

closes: #6008

etc/profile-m-z/tidal-hifi.profile Outdated Show resolved Hide resolved
etc/profile-m-z/tidal-hifi.profile Outdated Show resolved Hide resolved
etc/profile-m-z/tidal-hifi.profile Outdated Show resolved Hide resolved
etc/profile-m-z/tidal-hifi.profile Outdated Show resolved Hide resolved
etc/profile-m-z/tidal-hifi.profile Show resolved Hide resolved
etc/profile-m-z/tidal-hifi.profile Outdated Show resolved Hide resolved
etc/profile-m-z/tidal-hifi.profile Outdated Show resolved Hide resolved
etc/profile-m-z/tidal-hifi.profile Show resolved Hide resolved
etc/profile-m-z/tidal-hifi.profile Outdated Show resolved Hide resolved
etc/profile-m-z/tidal-hifi.profile Outdated Show resolved Hide resolved
etc/profile-m-z/tidal-hifi.profile Outdated Show resolved Hide resolved
etc/profile-m-z/tidal-hifi.profile Show resolved Hide resolved
etc/profile-m-z/tidal-hifi.profile Show resolved Hide resolved
etc/profile-m-z/tidal-hifi.profile Outdated Show resolved Hide resolved
Copy link
Collaborator

@glitsj16 glitsj16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the new private-etc syntax.

Copy link
Collaborator

@glitsj16 glitsj16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the private-etc changes. LGTM.

@jtrv jtrv requested a review from rusty-snake September 25, 2023 19:15
modified src/firecfg/firecfg.config to add tidal-hifi
created etc/profile-m-z/tidal-hifi.profile

closes: netblue30#6008

Apply suggestions from code review

Co-authored-by: rusty-snake <41237666+rusty-snake@users.noreply.github.com>
Copy link
Collaborator

@glitsj16 glitsj16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmk3 kmk3 changed the title New profile: tidal-hifi (#6008) New profile: tidal-hifi Sep 25, 2023
@netblue30
Copy link
Owner

merged, thanks

@netblue30 netblue30 merged commit 2a8621c into netblue30:master Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tidal-hifi
4 participants