Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: allow overriding certain tools & sync targets with CI #6222

Merged
merged 3 commits into from
Feb 28, 2024
Merged

build: allow overriding certain tools & sync targets with CI #6222

merged 3 commits into from
Feb 28, 2024

Commits on Feb 24, 2024

  1. build: allow overriding certain tools 

    Allow overriding the following tools at configure-time and build-time:

* codespell
* cppcheck
* gawk
* scan-build

For example, instead of hardcoding `gawk`, enable overriding it at
configure-time with:

    ./configure GAWK=/path/to/gawk

To override it for a single `make` invocation:

    make GAWK=/path/to/gawk

Also, add default values for the programs that are not found (rather
than leaving the variables empty), to make error messages clearer when
trying to run them:

    $ make CPPCHECK= cppcheck-old
    [...]
    force --error-exitcode=1 --enable=warning,performance .
    make: force: No such file or directory
    $ make CPPCHECK=cppcheck cppcheck-old
    [...]
    cppcheck --force --error-exitcode=1 --enable=warning,performance .
    make: cppcheck: No such file or directory
    @kmk3
    kmk3 committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    93d623f View commit details
    Browse the repository at this point in the history

  2. build: sync cppcheck targets with CI 

    Changes:

* Use the same command from the cppcheck CI job in the cppcheck target
* Add cppcheck-old target based on the cppcheck_old CI job
* Call the make targets in CI to avoid duplicating the commands
    @kmk3
    kmk3 committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    f4f7a81 View commit details
    Browse the repository at this point in the history

  3. build: sync scan-build target with CI 

    Changes:

* Use --status-bugs in the scan-build target to exit with an error if
  bugs are found
* Call the make target in the CI job
    @kmk3
    kmk3 committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    1f6400b View commit details
    Browse the repository at this point in the history