Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: man: improve blacklist/whitelist examples with spaces #6425

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

glitsj16
Copy link
Collaborator

@glitsj16 glitsj16 commented Jul 30, 2024

Use the same examples with spaces and make the quotes more consistent
with the other examples.

@kmk3 kmk3 changed the title man: firejail.1.in: fix whitelist example docs: man: improve quoting in blacklist/whitelist examples Jul 30, 2024
Use the same examples with spaces and make the quotes more consistent
with the other examples.
@kmk3 kmk3 changed the title docs: man: improve quoting in blacklist/whitelist examples docs: man: improve blacklist/whitelist examples with spaces Jul 30, 2024
@kmk3 kmk3 added the documentation Issues and pull requests related to the documentation label Jul 30, 2024
Copy link
Collaborator

@kmk3 kmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Note that the quoting works in both cases, but the changes do make them more
consistent with the other examples.

@glitsj16
Copy link
Collaborator Author

@kmk3

Thanks for also treating the blacklist example the same way.

Note that the quoting works in both cases, but the changes do make them more
consistent with the other examples.

Indeed. There was some confusion about the quoting reported on IRC, which was the motivation behind my PR.

Regards

@glitsj16 glitsj16 merged commit 886fb7d into netblue30:master Jul 30, 2024
2 checks passed
@glitsj16 glitsj16 deleted the man-fix branch July 30, 2024 18:23
kmk3 added a commit that referenced this pull request Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues and pull requests related to the documentation
Projects
Status: Done (on RELNOTES)
Development

Successfully merging this pull request may close these issues.

2 participants