Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New profile: irssi #6549

Merged
merged 13 commits into from
Dec 17, 2024
Merged

New profile: irssi #6549

merged 13 commits into from
Dec 17, 2024

Conversation

gcb
Copy link
Contributor

@gcb gcb commented Nov 18, 2024

cross irssi off the wanted list #1139

I think it will work, but I don't have how to test DCC, because well, like the entire universe i'm behind layers of NAT, CGNAT, etc... and nobody should use DCC anyway.

etc/profile-a-l/irssi.profile Outdated Show resolved Hide resolved
etc/profile-a-l/irssi.profile Outdated Show resolved Hide resolved
etc/profile-a-l/irssi.profile Outdated Show resolved Hide resolved
etc/profile-a-l/irssi.profile Outdated Show resolved Hide resolved
etc/profile-a-l/irssi.profile Outdated Show resolved Hide resolved
etc/profile-a-l/irssi.profile Outdated Show resolved Hide resolved
etc/profile-a-l/irssi.profile Outdated Show resolved Hide resolved
etc/profile-a-l/irssi.profile Show resolved Hide resolved
etc/profile-a-l/irssi.profile Outdated Show resolved Hide resolved
etc/profile-a-l/irssi.profile Show resolved Hide resolved
gcb and others added 6 commits November 18, 2024 20:03
Co-authored-by: rusty-snake <41237666+rusty-snake@users.noreply.github.com>
Co-authored-by: rusty-snake <41237666+rusty-snake@users.noreply.github.com>
Co-authored-by: rusty-snake <41237666+rusty-snake@users.noreply.github.com>
@rusty-snake rusty-snake dismissed their stale review November 18, 2024 20:41

almost resolved, give chance to other reviewers

@kmk3 kmk3 changed the title irssi support New profile: irssi Nov 19, 2024
etc/profile-a-l/irssi.profile Outdated Show resolved Hide resolved
etc/profile-a-l/irssi.profile Outdated Show resolved Hide resolved
etc/profile-a-l/irssi.profile Outdated Show resolved Hide resolved
etc/profile-a-l/irssi.profile Outdated Show resolved Hide resolved
etc/inc/disable-programs.inc Outdated Show resolved Hide resolved
@gcb gcb requested a review from kmk3 November 23, 2024 13:17

disable-mnt
private-cache
private-dev
Copy link
Collaborator

@kmk3 kmk3 Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private-dev
private-dev
private-etc @network,@tls-ca

Does it work with private-etc?

Note: The @group syntax only exists in firejail-git.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had installed -git to test with the notpm line, but now i'm back to my distro version and did not test private-etc. I will test with -git later on and report. But I don't see why not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead I ran it now in debugger, also watching lsof for the pid, and nothing on etc is ever touched. I think it is OK.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead I ran it now in debugger, also watching lsof for the pid, and
nothing on etc is ever touched. I think it is OK.

Can you test connecting to a server in firejail-git to make sure?

It seems strange that nothing on /etc would be accessed (such as TLS-related
paths).

What is the output of trace.txt in the following?

firejail --trace=trace.txt --profile=irssi /usr/bin/irssi

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. My irssi profile is very uncommon. Retested this with a clean irssi profile, and indeed, it does break dns as expected.

with private-etc: Irssi: Unable to connect server irc.freenode.net port 6667 [Temporary failure in name resolution]

without: resolves names fine.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. My irssi profile is very uncommon. Retested this with a clean irssi
profile, and indeed, it does break dns as expected.

with private-etc: Irssi: Unable to connect server irc.freenode.net port 6667
[Temporary failure in name resolution]

without: resolves names fine.

Strange, what program do you use to manage dns?

On what distribution name/version?

Also, could you retest with the current irssi.profile in firejail-git (there is
one new change) and post the output of trace.txt?

@kmk3 kmk3 mentioned this pull request Nov 25, 2024
@netblue30 netblue30 merged commit 1fb970e into netblue30:master Dec 17, 2024
8 checks passed
@netblue30
Copy link
Owner

Thanks for the patch, merging in!

@netblue30
Copy link
Owner

netblue30 commented Dec 17, 2024

I added and commented out (see kmk3 above):

# private-etc @network,@tls-ca

@gcb give it a try, maybe is working. Thanks.

@gcb gcb deleted the gcb-patch-1 branch December 17, 2024 16:20
kmk3 added a commit that referenced this pull request Dec 19, 2024
Added on commit bed96d1 ("merges", 2024-12-17).

Relates to #6549.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

4 participants