Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IGNORE_SSL_ERRORS not propigating #95

Closed
skyefugate opened this issue Jul 27, 2023 · 2 comments
Closed

IGNORE_SSL_ERRORS not propigating #95

skyefugate opened this issue Jul 27, 2023 · 2 comments
Labels
status: accepted status: acknowledged An acknowledged question/issue for easy sorting by maintainers

Comments

@skyefugate
Copy link

Hi -- I tried running the importer on my instance of Netbox and I ran into issues where when I set the IGNORE_SSL_ERRORS to 'True' it was not propagating all the way. The resolution to this was to set line 481 in netbox_api.py to the below.

response = requests.patch(url, headers=headers, files=files, verify=False)

What was added was ', verify=False'

This just needs to take the propagation from the .env file to fix. Thanks!
@danner26
Copy link
Member

Thank you for this. This also assisted us in catching an issue with permissions that we did not know about previously.

danner26 added a commit to danner26/Device-Type-Library-Import that referenced this issue Jul 31, 2023
@danner26
fixing the requests verify missing issue netbox-community#95
bc47f1c
@danner26 danner26 mentioned this issue Jul 31, 2023
Merged
danner26 added a commit that referenced this issue Jul 31, 2023
@danner26
fixing the requests verify missing issue #95 (#96)
d3916aa
danner26 added a commit that referenced this issue Jul 31, 2023
@danner26 @jbemmel
Version 2.0.1 (#97)
8ad3ed7 
* Fix image upload v2 (#91)

* Add upload_image functionality to new beta script

* Updated for new location of files with Boolean flag for front/rear image

* fixing the requests verify missing issue #95 (#96)

---------

Co-authored-by: J vanBemmel <jvb127@gmail.com>
@danner26
Copy link
Member

This issue is now resolved in Release v2.0.1

@danner26 danner26 added status: accepted status: acknowledged An acknowledged question/issue for easy sorting by maintainers labels Jul 31, 2023
danner26 added a commit that referenced this issue Aug 1, 2023
@danner26 @jbemmel
Release v2.0.2 (#102)
136344d 
* Fix image upload v2 (#91)

* Add upload_image functionality to new beta script

* Updated for new location of files with Boolean flag for front/rear image

* fixing the requests verify missing issue #95 (#96)

* Bumping deps. Closes PR#99 and PR#98 (#100)

* Added ability for IGNORE_SSL_ERRORS to dictate if the images upload verifys the request (#101)

---------

Co-authored-by: J vanBemmel <jvb127@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepted status: acknowledged An acknowledged question/issue for easy sorting by maintainers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danner26 @skyefugate